From: Luciano Coelho <coelho@ti.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Sebastien Jan <s-jan@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] WLAN: fix the path to the wl12xx firmwares
Date: Wed, 23 Feb 2011 16:54:25 +0200 [thread overview]
Message-ID: <1298472865.2104.48.camel@pimenta> (raw)
In-Reply-To: <20110223144134.GA2729@tuxdriver.com>
On Wed, 2011-02-23 at 09:41 -0500, John W. Linville wrote:
> > > diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
> > > index 9050dd9..8ceb6a0 100644
> > > --- a/drivers/net/wireless/wl12xx/wl12xx.h
> > > +++ b/drivers/net/wireless/wl12xx/wl12xx.h
> > > @@ -112,8 +112,8 @@ extern u32 wl12xx_debug_level;
> > > CFG_RX_CTL_EN | CFG_RX_BCN_EN | \
> > > CFG_RX_AUTH_EN | CFG_RX_ASSOC_EN)
> > >
> > > -#define WL1271_FW_NAME "wl1271-fw.bin"
> > > -#define WL1271_NVS_NAME "wl1271-nvs.bin"
> > > +#define WL1271_FW_NAME "ti-connectivity/wl1271-fw.bin"
> > > +#define WL1271_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
> >
> > You're right. Our firmware is (unfortunately) inside the
> > ti-connectivity in linux-firmware.git. So it would make sense to
> > include the ti-connectivity/ directory when requesting for the firmware,
> > but it's just damn ugly. :( The driver should not care at all where the
> > firmware is to be fetched from, that should be up to the userspace.
> >
> > Dunno what is the best thing to do about this. Add the directory to the
> > driver? Move the wl1271*.bin files to the root of linux-firmware? Does
> > anybody have opinions about it?
>
> I think there are a number of other drivers with embedded pathnames.
Indeed. And, as discussed with Johannes on IRC, the / will be just one
more character in the FW name, regardless of whether it means a
subdirectory or not. It's just part of the FW name string.
When I apply the patch, I just need to brace for the loads of people
complaining that the FW cannot be found anymore and explain the issue a
hundred times. ;)
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-02-23 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 13:25 [PATCH] WLAN: fix the path to the wl12xx firmwares Sebastien Jan
2011-02-23 14:33 ` Luciano Coelho
2011-02-23 14:41 ` John W. Linville
2011-02-23 14:54 ` Luciano Coelho [this message]
2011-02-23 15:15 ` Larry Finger
2011-03-03 15:39 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298472865.2104.48.camel@pimenta \
--to=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=s-jan@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).