From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Daniel Halperin <dhalperi@cs.washington.edu>,
Swati Rallapalli <swati@cs.utexas.edu>
Subject: Re: [PATCH 2/2] iwlagn: fix iwlagn_check_needed_chains
Date: Fri, 25 Feb 2011 07:31:13 -0800 [thread overview]
Message-ID: <1298647873.28351.10.camel@wwguy-huron> (raw)
In-Reply-To: <1298648386.4329.18.camel@jlt3.sipsolutions.net>
On Fri, 2011-02-25 at 07:39 -0800, Johannes Berg wrote:
> On Fri, 2011-02-25 at 07:36 -0800, wwguy wrote:
>
> > > @@ -503,7 +488,46 @@ static void iwlagn_check_needed_chains(s
> > > * will soon tell us about that.
> > > */
> > > need_multiple = false;
> > > + rcu_read_unlock();
> > > + break;
> >
> > why unlock and break here instead stay do it later like before?
>
> Only because the indentation there was getting so deep it was annoying
> to fit into 80 cols :-)
how you want to submit this patch? through iwlagn, or yo uwill send it
along with mac80211 to John?
Wey
>
next prev parent reply other threads:[~2011-02-25 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 11:24 [PATCH 0/2] fix iwlwifi needed RX chains Johannes Berg
2011-02-25 11:24 ` [PATCH 1/2] mac80211: copy peer MCS TX parameters Johannes Berg
2011-02-25 11:24 ` [PATCH 2/2] iwlagn: fix iwlagn_check_needed_chains Johannes Berg
2011-02-25 15:36 ` wwguy
2011-02-25 15:39 ` Johannes Berg
2011-02-25 15:31 ` Guy, Wey-Yi [this message]
2011-02-25 15:49 ` Johannes Berg
2011-02-26 17:59 ` Daniel Halperin
2011-02-26 18:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298647873.28351.10.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=dhalperi@cs.washington.edu \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=swati@cs.utexas.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).