From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] iwlwifi: ack,plcp check health changes
Date: Fri, 25 Feb 2011 08:58:09 -0800 [thread overview]
Message-ID: <1298653089.28351.26.camel@wwguy-huron> (raw)
In-Reply-To: <1298649432-4416-3-git-send-email-sgruszka@redhat.com>
On Fri, 2011-02-25 at 07:57 -0800, Stanislaw Gruszka wrote:
> Add module ack_check, and plcp_check parameters, Ack_check is disabled
> by default since is proved that check ack health can cause troubles.
> Plcp_check is enabled by default.
>
> Remove iwl_lib_ops methods, they are unneeded after iwlegacy driver
> split. Merge check health code into to iwl-rx.c and make functions
> static.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-1000.c | 2 -
> drivers/net/wireless/iwlwifi/iwl-2000.c | 2 -
> drivers/net/wireless/iwlwifi/iwl-5000.c | 4 -
> drivers/net/wireless/iwlwifi/iwl-6000.c | 4 -
> drivers/net/wireless/iwlwifi/iwl-agn-lib.c | 1 +
> drivers/net/wireless/iwlwifi/iwl-agn-rx.c | 87 ---------------
> drivers/net/wireless/iwlwifi/iwl-agn.c | 73 ++-----------
> drivers/net/wireless/iwlwifi/iwl-agn.h | 4 -
> drivers/net/wireless/iwlwifi/iwl-core.h | 9 +-
> drivers/net/wireless/iwlwifi/iwl-rx.c | 162 ++++++++++++++++++++++++++-
> 10 files changed, 167 insertions(+), 181 deletions(-)
>
looks good, just wonder should it split into 2 patches, one for module
parameter, and the other for moving the function?
Your call
Wey
next prev parent reply other threads:[~2011-02-25 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 15:57 [PATCH v2 1/3] iwlwifi: fix dma mappings and skbs leak Stanislaw Gruszka
2011-02-25 15:57 ` [PATCH 2/3] iwlegacy: " Stanislaw Gruszka
2011-02-25 16:49 ` Guy, Wey-Yi
2011-02-25 15:57 ` [PATCH 3/3] iwlwifi: ack,plcp check health changes Stanislaw Gruszka
2011-02-25 16:58 ` Guy, Wey-Yi [this message]
2011-02-25 16:47 ` [PATCH v2 1/3] iwlwifi: fix dma mappings and skbs leak Guy, Wey-Yi
2011-02-28 9:24 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298653089.28351.26.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).