From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] at76c50x-usb: fix warning caused by at76_mac80211_tx now returning void
Date: Fri, 25 Feb 2011 21:47:14 +0100 [thread overview]
Message-ID: <1298666834.4329.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1298666447-30028-1-git-send-email-linville@tuxdriver.com>
On Fri, 2011-02-25 at 15:40 -0500, John W. Linville wrote:
> CC [M] drivers/net/wireless/at76c50x-usb.o
> drivers/net/wireless/at76c50x-usb.c: In function ‘at76_mac80211_tx’:
> drivers/net/wireless/at76c50x-usb.c:1759:4: warning: ‘return’ with a value, in function returning void
>
> This is fallout from commit 7bb4568372856688bc070917265bce0b88bb7d4d
> ("mac80211: make tx() operation return void").
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/at76c50x-usb.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c
> index 10b4393..a37c93b 100644
> --- a/drivers/net/wireless/at76c50x-usb.c
> +++ b/drivers/net/wireless/at76c50x-usb.c
> @@ -1756,7 +1756,6 @@ static void at76_mac80211_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
> if (compare_ether_addr(priv->bssid, mgmt->bssid)) {
> memcpy(priv->bssid, mgmt->bssid, ETH_ALEN);
> ieee80211_queue_work(hw, &priv->work_join_bssid);
> - return NETDEV_TX_BUSY;
I guess I missed this one -- bit it needs to free the SKB otherwise it
probably leaks.
johannes
next prev parent reply other threads:[~2011-02-25 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 20:40 [PATCH] at76c50x-usb: fix warning caused by at76_mac80211_tx now returning void John W. Linville
2011-02-25 20:47 ` Johannes Berg [this message]
2011-02-25 22:03 ` [PATCH v2] " John W. Linville
2011-02-26 9:21 ` Johannes Berg
2011-02-26 10:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298666834.4329.20.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox