linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <martinez.javier@gmail.com>
To: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>,
	Dowan Kim <dowan@broadcom.com>,
	Roland Vossen <rvossen@broadcom.com>,
	Arend van Spriel <arend@broadcom.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	Javier Martinez Canillas <martinez.javier@gmail.com>
Subject: [PATCH 2/2] staging: brcm80211: Remove unused variables and code clean up
Date: Sun, 27 Feb 2011 21:54:15 +0100	[thread overview]
Message-ID: <1298840055-5044-2-git-send-email-martinez.javier@gmail.com> (raw)
In-Reply-To: <1298840055-5044-1-git-send-email-martinez.javier@gmail.com>

tsf_l and tsf_h variables where used in a code segment that is never compiled
so the variables remains unused. 

Remove those variables and the code never compiled as well.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
 drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c b/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c
index 464e421..69717ae 100644
--- a/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c
+++ b/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c
@@ -6875,21 +6875,12 @@ static void
 prep_mac80211_status(struct wlc_info *wlc, d11rxhdr_t *rxh, struct sk_buff *p,
 		     struct ieee80211_rx_status *rx_status)
 {
-	u32 tsf_l, tsf_h;
 	wlc_d11rxhdr_t *wlc_rxh = (wlc_d11rxhdr_t *) rxh;
 	int preamble;
 	int channel;
 	ratespec_t rspec;
 	unsigned char *plcp;
 
-#if 0
-	/* Clearly, this is bogus -- reading the TSF now is wrong */
-	wlc_read_tsf(wlc, &tsf_l, &tsf_h);	/* mactime */
-	rx_status->mactime = tsf_h;
-	rx_status->mactime <<= 32;
-	rx_status->mactime |= tsf_l;
-	rx_status->flag |= RX_FLAG_MACTIME_MPDU; /* clearly wrong */
-#endif
 
 	channel = WLC_CHAN_CHANNEL(rxh->RxChan);
 
-- 
1.7.2.3


  reply	other threads:[~2011-02-27 20:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-27 20:54 [PATCH 1/2] staging: brcm80211: Add buf_size parameter to ampdu_action handler function Javier Martinez Canillas
2011-02-27 20:54 ` Javier Martinez Canillas [this message]
2011-03-01  3:11   ` [PATCH 2/2] staging: brcm80211: Remove unused variables and code clean up Greg KH
2011-03-01 15:37     ` Javier Martinez Canillas
2011-03-01 15:48       ` Greg KH
2011-03-01 16:03       ` Dan Carpenter
2011-03-03 11:30         ` Javier Martinez Canillas
2011-02-28  9:50 ` [PATCH 1/2] staging: brcm80211: Add buf_size parameter to ampdu_action handler function Roland Vossen
2011-03-02 19:23 ` Arend van Spriel
2011-03-03 11:50   ` Javier Martinez Canillas
2011-03-03 15:38     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298840055-5044-2-git-send-email-martinez.javier@gmail.com \
    --to=martinez.javier@gmail.com \
    --cc=arend@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dowan@broadcom.com \
    --cc=gregkh@suse.de \
    --cc=henryp@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rvossen@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).