From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
George <george0505@realtek.com>,
linux-next@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB
Date: Mon, 28 Feb 2011 21:08:51 +0100 [thread overview]
Message-ID: <1298923731.10109.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1298922500-21632-1-git-send-email-linville@tuxdriver.com>
On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote:
>
> +ifeq ($(CONFIG_USB),y)
> +rtlwifi-objs += usb.o
> +endif
That reads weird, shouldn't
rtlwifi-$(CONFIG_USB) += usb.o
do? Or more likely actually use CONFIG_RTL8192CU?
johannes
next prev parent reply other threads:[~2011-02-28 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 12:56 [-next] ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! Geert Uytterhoeven
2011-02-28 19:48 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB John W. Linville
2011-02-28 20:08 ` Johannes Berg [this message]
2011-02-28 20:13 ` John W. Linville
2011-02-28 21:16 ` Larry Finger
2011-02-28 21:21 ` Johannes Berg
2011-02-28 21:27 ` Larry Finger
2011-03-01 18:53 ` [PATCH v2] " John W. Linville
2011-03-01 19:54 ` Larry Finger
2011-02-28 21:01 ` [PATCH] " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298923731.10109.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=geert@linux-m68k.org \
--cc=george0505@realtek.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).