From: Joe Perches <joe@perches.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro
Date: Mon, 28 Feb 2011 21:25:38 -0800 [thread overview]
Message-ID: <1298957138.4367.3.camel@Joe-Laptop> (raw)
In-Reply-To: <1298956016-30673-2-git-send-email-bzhao@marvell.com>
On Mon, 2011-02-28 at 21:06 -0800, Bing Zhao wrote:
> dynamic_hexdump_debug(str, buf, len)
> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> +#define dynamic_hexdump_debug(str, buf, len) \
> +do { \
> + static struct _ddebug descriptor \
> + __used \
> + __attribute__((section("__verbose"), aligned(8))) = \
> + { KBUILD_MODNAME, __func__, __FILE__, str, __LINE__, \
> + _DPRINTK_FLAGS_DEFAULT }; \
> + if (unlikely(descriptor.enabled)) { \
> + printk(KERN_DEBUG str); \
> + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); \
Perhaps
print_hex_dump(str, DUMP_PREFIX_OFFSET, buf, len);
next prev parent reply other threads:[~2011-03-01 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 5:06 [RFC v2 0/2] hexdump dynamic debug Bing Zhao
2011-03-01 5:06 ` [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro Bing Zhao
2011-03-01 5:25 ` Joe Perches [this message]
2011-03-01 19:33 ` Bing Zhao
2011-03-01 5:06 ` [RFC v2 2/2] printk: add hexdump_debug macro Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298957138.4367.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox