* [RFC v2 0/2] hexdump dynamic debug @ 2011-03-01 5:06 Bing Zhao 2011-03-01 5:06 ` [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro Bing Zhao 2011-03-01 5:06 ` [RFC v2 2/2] printk: add hexdump_debug macro Bing Zhao 0 siblings, 2 replies; 5+ messages in thread From: Bing Zhao @ 2011-03-01 5:06 UTC (permalink / raw) To: linux-kernel Cc: linux-wireless, John W. Linville, Johannes Berg, Amitkumar Karwar, Kiran Divekar, Frank Huang, Bing Zhao This patchset adds hexdump macros utilizing dynamic debug. v2: rebase against linux-next.git tree and split into 2 patches Bing Zhao (2): dynamic debug: add dynamic_hexdump_debug macro printk: add hexdump_debug macro include/linux/dynamic_debug.h | 22 ++++++++++++++++++++++ include/linux/printk.h | 14 ++++++++++++++ 2 files changed, 36 insertions(+), 0 deletions(-) ^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro 2011-03-01 5:06 [RFC v2 0/2] hexdump dynamic debug Bing Zhao @ 2011-03-01 5:06 ` Bing Zhao 2011-03-01 5:25 ` Joe Perches 2011-03-01 5:06 ` [RFC v2 2/2] printk: add hexdump_debug macro Bing Zhao 1 sibling, 1 reply; 5+ messages in thread From: Bing Zhao @ 2011-03-01 5:06 UTC (permalink / raw) To: linux-kernel Cc: linux-wireless, John W. Linville, Johannes Berg, Amitkumar Karwar, Kiran Divekar, Frank Huang, Bing Zhao dynamic_hexdump_debug(str, buf, len) str: "subject string" buf: buffer pointer len: length of the buffer being printed Signed-off-by: Bing Zhao <bzhao@marvell.com> --- include/linux/dynamic_debug.h | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 0c9653f..429a176 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -70,6 +70,19 @@ extern int __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...) dev_printk(KERN_DEBUG, dev, fmt, ##__VA_ARGS__); \ } while (0) +#define dynamic_hexdump_debug(str, buf, len) \ +do { \ + static struct _ddebug descriptor \ + __used \ + __attribute__((section("__verbose"), aligned(8))) = \ + { KBUILD_MODNAME, __func__, __FILE__, str, __LINE__, \ + _DPRINTK_FLAGS_DEFAULT }; \ + if (unlikely(descriptor.enabled)) { \ + printk(KERN_DEBUG str); \ + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); \ + } \ +} while (0) + #else static inline int ddebug_remove_module(const char *mod) @@ -81,6 +94,15 @@ static inline int ddebug_remove_module(const char *mod) do { if (0) printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); } while (0) #define dynamic_dev_dbg(dev, fmt, ...) \ do { if (0) dev_printk(KERN_DEBUG, dev, fmt, ##__VA_ARGS__); } while (0) + +#define dynamic_hexdump_debug(str, buf, len) \ +do { \ + if (0) { \ + printk(KERN_DEBUG str); \ + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); \ + } \ +} while (0) + #endif #endif -- 1.6.2.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro 2011-03-01 5:06 ` [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro Bing Zhao @ 2011-03-01 5:25 ` Joe Perches 2011-03-01 19:33 ` Bing Zhao 0 siblings, 1 reply; 5+ messages in thread From: Joe Perches @ 2011-03-01 5:25 UTC (permalink / raw) To: Bing Zhao Cc: linux-kernel, linux-wireless, John W. Linville, Johannes Berg, Amitkumar Karwar, Kiran Divekar, Frank Huang On Mon, 2011-02-28 at 21:06 -0800, Bing Zhao wrote: > dynamic_hexdump_debug(str, buf, len) > diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h > +#define dynamic_hexdump_debug(str, buf, len) \ > +do { \ > + static struct _ddebug descriptor \ > + __used \ > + __attribute__((section("__verbose"), aligned(8))) = \ > + { KBUILD_MODNAME, __func__, __FILE__, str, __LINE__, \ > + _DPRINTK_FLAGS_DEFAULT }; \ > + if (unlikely(descriptor.enabled)) { \ > + printk(KERN_DEBUG str); \ > + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); \ Perhaps print_hex_dump(str, DUMP_PREFIX_OFFSET, buf, len); ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro 2011-03-01 5:25 ` Joe Perches @ 2011-03-01 19:33 ` Bing Zhao 0 siblings, 0 replies; 5+ messages in thread From: Bing Zhao @ 2011-03-01 19:33 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, John W. Linville, Johannes Berg, Amitkumar Karwar, Kiran Divekar, Frank Huang SGkgSm9lLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEpvZSBQZXJj aGVzIFttYWlsdG86am9lQHBlcmNoZXMuY29tXQ0KPiBTZW50OiBNb25kYXksIEZlYnJ1YXJ5IDI4 LCAyMDExIDk6MjYgUE0NCj4gVG86IEJpbmcgWmhhbw0KPiBDYzogbGludXgta2VybmVsQHZnZXIu a2VybmVsLm9yZzsgbGludXgtd2lyZWxlc3NAdmdlci5rZXJuZWwub3JnOyBKb2huIFcuIExpbnZp bGxlOyBKb2hhbm5lcyBCZXJnOw0KPiBBbWl0a3VtYXIgS2Fyd2FyOyBLaXJhbiBEaXZla2FyOyBG cmFuayBIdWFuZw0KPiBTdWJqZWN0OiBSZTogW1JGQyB2MiAxLzJdIGR5bmFtaWMgZGVidWc6IGFk ZCBkeW5hbWljX2hleGR1bXBfZGVidWcgbWFjcm8NCj4gDQo+IE9uIE1vbiwgMjAxMS0wMi0yOCBh dCAyMTowNiAtMDgwMCwgQmluZyBaaGFvIHdyb3RlOg0KPiA+IGR5bmFtaWNfaGV4ZHVtcF9kZWJ1 ZyhzdHIsIGJ1ZiwgbGVuKQ0KPiANCj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9keW5h bWljX2RlYnVnLmggYi9pbmNsdWRlL2xpbnV4L2R5bmFtaWNfZGVidWcuaA0KPiA+ICsjZGVmaW5l IGR5bmFtaWNfaGV4ZHVtcF9kZWJ1ZyhzdHIsIGJ1ZiwgbGVuKQkJCQlcDQo+ID4gK2RvIHsJCQkJ CQkJCQlcDQo+ID4gKwlzdGF0aWMgc3RydWN0IF9kZGVidWcgZGVzY3JpcHRvcgkJCQlcDQo+ID4g KwlfX3VzZWQJCQkJCQkJCVwNCj4gPiArCV9fYXR0cmlidXRlX18oKHNlY3Rpb24oIl9fdmVyYm9z ZSIpLCBhbGlnbmVkKDgpKSkgPQkJXA0KPiA+ICsJeyBLQlVJTERfTU9ETkFNRSwgX19mdW5jX18s IF9fRklMRV9fLCBzdHIsIF9fTElORV9fLAkJXA0KPiA+ICsJCV9EUFJJTlRLX0ZMQUdTX0RFRkFV TFQgfTsJCQkJXA0KPiA+ICsJaWYgKHVubGlrZWx5KGRlc2NyaXB0b3IuZW5hYmxlZCkpIHsJCQkJ XA0KPiA+ICsJCXByaW50ayhLRVJOX0RFQlVHIHN0cik7CQkJCQlcDQo+ID4gKwkJcHJpbnRfaGV4 X2R1bXBfYnl0ZXMoIiIsIERVTVBfUFJFRklYX09GRlNFVCwgYnVmLCBsZW4pOwlcDQo+IA0KPiBQ ZXJoYXBzDQo+IAkJcHJpbnRfaGV4X2R1bXAoc3RyLCBEVU1QX1BSRUZJWF9PRkZTRVQsIGJ1Ziwg bGVuKTsNCg0KSSB3YW50ZWQgdG8gcHJpbnQgdGhlICJzdHIiIGFzIGEgc3ViamVjdCBsaW5lLCBs aWtlIHRoaXM6DQoNCm13aWZpZXggZGF0YTogdHhfYnVmOg0KMDAwMDAwMDA6IDM0IDhjIDI0IGEw IGZmIGZmIGZmIGZmIDM2IDcyIDI0IGEwIGZmIGZmIGZmIGZmICA0LiQuLi4uLjZyJC4uLi4uDQow MDAwMDAxMDogZDcgN2YgMjQgYTAgZmYgZmYgZmYgZmYgODAgOGUgMjQgYTAgZmYgZmYgZmYgZmYg IC4uJC4uLi4uLi4kLi4uLi4NCjAwMDAwMDIwOiBkZiA3ZCAyNCBhMCBmZiBmZiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLn0kLi4uDQoNClRoZSAic3RyIiB3aWxsIHNlcnZlIGFzIHRo ZSBwcmVmaXggc3RyaW5ncyBpZiB3ZSB1c2UNCnByaW50X2hleF9kdW1wKEtFUk5fREVCVUcsIHN0 ciwgRFVNUF9QUkVGSVhfT0ZGU0VULCAxNiwgMSwgYnVmLCBsZW4sIHRydWUpOw0KDQptd2lmaWV4 IGRhdGE6IHR4X2J1ZjowMDAwMDAwMDogMzQgOGMgMjQgYTAgZmYgZmYgZmYgZmYgMzYgNzIgMjQg YTAgZmYgZmYgZmYgZmYgIDQuJC4uLi4uNnIkLi4uLi4NCm13aWZpZXggZGF0YTogdHhfYnVmOjAw MDAwMDEwOiBkNyA3ZiAyNCBhMCBmZiBmZiBmZiBmZiA4MCA4ZSAyNCBhMCBmZiBmZiBmZiBmZiAg Li4kLi4uLi4uLiQuLi4uLg0KbXdpZmlleCBkYXRhOiB0eF9idWY6MDAwMDAwMjA6IGRmIDdkIDI0 IGEwIGZmIGZmICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAufSQuLi4NCg0KSSdtIG9r YXkgd2l0aCB0aGlzIGZvcm1hdCB0b28uDQoNClRoYW5rcywNCg0KQmluZw0KDQo= ^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC v2 2/2] printk: add hexdump_debug macro 2011-03-01 5:06 [RFC v2 0/2] hexdump dynamic debug Bing Zhao 2011-03-01 5:06 ` [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro Bing Zhao @ 2011-03-01 5:06 ` Bing Zhao 1 sibling, 0 replies; 5+ messages in thread From: Bing Zhao @ 2011-03-01 5:06 UTC (permalink / raw) To: linux-kernel Cc: linux-wireless, John W. Linville, Johannes Berg, Amitkumar Karwar, Kiran Divekar, Frank Huang, Bing Zhao hexdump_debug(str, buf, len) str: "subject string" buf: buffer pointer len: length of the buffer being printed usage: hexdump_debug("mwifiex data: tx_buf:\n", tx_buf, 32); Signed-off-by: Bing Zhao <bzhao@marvell.com> --- include/linux/printk.h | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index ee048e7..c758131 100644 --- a/include/linux/printk.h +++ b/include/linux/printk.h @@ -299,4 +299,18 @@ static inline void print_hex_dump_bytes(const char *prefix_str, int prefix_type, #endif +#if defined(DEBUG) +#define hexdump_debug(str, buf, len) \ +do { \ + printk(KERN_DEBUG str); \ + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); \ +} while (0) +#elif defined(CONFIG_DYNAMIC_DEBUG) +#define hexdump_debug(str, buf, len) \ + dynamic_hexdump_debug(str, buf, len) +#else +#define hexdump_debug(str, buf, len) \ + no_printk(KERN_DEBUG str) +#endif + #endif -- 1.6.2.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-01 19:34 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-03-01 5:06 [RFC v2 0/2] hexdump dynamic debug Bing Zhao 2011-03-01 5:06 ` [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro Bing Zhao 2011-03-01 5:25 ` Joe Perches 2011-03-01 19:33 ` Bing Zhao 2011-03-01 5:06 ` [RFC v2 2/2] printk: add hexdump_debug macro Bing Zhao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).