From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: hostap@lists.shmoo.com, Jouni Malinen <j@w1.fi>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] hostapd: Don't force HT Mixed Mode for non-GF STAs
Date: Wed, 02 Mar 2011 10:24:08 +0100 [thread overview]
Message-ID: <1299057848.4076.13.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201103021020.54806.helmut.schaa@googlemail.com>
On Wed, 2011-03-02 at 10:20 +0100, Helmut Schaa wrote:
> > static bool rs_use_green(struct ieee80211_sta *sta)
> > {
> > struct iwl_station_priv *sta_priv = (void *)sta->drv_priv;
> > struct iwl_rxon_context *ctx = sta_priv->common.ctx;
> >
> > return (sta->ht_cap.cap & IEEE80211_HT_CAP_GRN_FLD) &&
> > !(ctx->ht.non_gf_sta_present);
> > }
>
> Hmm, that looks a bit fishy as well. iwlagn should be allowed to use GF
> in that case, it just needs to protect it.
Right. That looks like it'd be a bit more tricky, and I don't think I
care right now.
johannes
prev parent reply other threads:[~2011-03-02 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1299055031-25080-1-git-send-email-helmut.schaa@googlemail.com>
[not found] ` <201103020953.17701.helmut.schaa@googlemail.com>
[not found] ` <1299056258.4076.8.camel@jlt3.sipsolutions.net>
2011-03-02 9:13 ` [PATCH] hostapd: Don't force HT Mixed Mode for non-GF STAs Helmut Schaa
2011-03-02 9:18 ` Johannes Berg
2011-03-02 9:20 ` Helmut Schaa
2011-03-02 9:24 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299057848.4076.13.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=hostap@lists.shmoo.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox