From: Luciano Coelho <coelho@ti.com>
To: Ido Yariv <ido@wizery.com>
Cc: linux-wireless@vger.kernel.org, Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH] wl12xx: Don't rely on runtime PM for toggling power
Date: Thu, 03 Mar 2011 17:42:21 +0200 [thread overview]
Message-ID: <1299166941.7039.4.camel@cumari> (raw)
In-Reply-To: <1298844838-11845-1-git-send-email-ido@wizery.com>
On Mon, 2011-02-28 at 00:13 +0200, Ido Yariv wrote:
> Runtime PM might not always be enabled. Even if it is enabled in the
> running kernel, it can still be temporarily disabled, for instance
> during suspend. Runtime PM is opportunistic in nature, and should not be
> relied on for toggling power.
>
> In case the interface is removed and re-added while runtime PM is
> disabled, the FW will fail to boot, as it is mandatory to toggle power
> between boots. For instance, this can happen during suspend in case one
> of the devices fails to suspend before the MMC host suspends, but after
> mac80211 was suspended. The interface will be removed and reactivated
> without toggling the power.
>
> Fix this by calling mmc_power_save_host/mmc_power_restore_host in
> wl1271_sdio_power_on/off functions. It will toggle the power to the chip
> even if runtime PM is disabled. The runtime PM functions should still be
> called to make sure runtime PM does not opportunistically power the chip
> off (e.g. after resuming from system suspend).
>
> Signed-off-by: Ido Yariv <ido@wizery.com>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
Applied, thanks!
--
Cheers,
Luca.
prev parent reply other threads:[~2011-03-03 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 22:13 [PATCH] wl12xx: Don't rely on runtime PM for toggling power Ido Yariv
2011-03-03 15:42 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299166941.7039.4.camel@cumari \
--to=coelho@ti.com \
--cc=ido@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox