From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Reinette Chatre <reinette.chatre@intel.com>,
Wey-Yi W Guy <wey-yi.w.guy@intel.com>
Subject: Re: [PATCH] iwlagn: fix offchannel TX bug
Date: Mon, 07 Mar 2011 20:02:15 +0100 [thread overview]
Message-ID: <1299524535.6739.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110307185429.GD2664@tuxdriver.com>
On Mon, 2011-03-07 at 13:54 -0500, John W. Linville wrote:
> > --- a/drivers/net/wireless/iwlwifi/iwl-agn.c 2011-03-05 19:32:58.000000000 +0100
> > +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c 2011-03-05 19:33:08.000000000 +0100
> > @@ -3171,7 +3171,7 @@ static int iwl_mac_offchannel_tx(struct
> > out:
> > mutex_unlock(&priv->mutex);
> > free:
> > - if (ret)
> > + if (ret < 0)
> > kfree_skb(skb);
> >
> > return ret;
>
> OK, I give-up...what tree is this against? :-)
Oh dang, it's against our own tree and I thought we'd already sent out
the patch "iwlagn: support off-channel TX". Clearly, that isn't the
case. Wey-yi, can you please merge this fix with the patch?
Sorry about that!
johannes
next prev parent reply other threads:[~2011-03-07 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 18:35 [PATCH] iwlagn: fix offchannel TX bug Johannes Berg
2011-03-07 18:54 ` John W. Linville
2011-03-07 19:02 ` Johannes Berg [this message]
2011-03-07 19:44 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299524535.6739.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).