[PATCH] brcmfmac: Add DMI nvram filename quirk for Acer A1 840 tablet

[PATCH] brcmfmac: Add DMI nvram filename quirk for Acer A1 840 tablet

[Hans de Goede]

The Acer A1 840 tablet contains quite generic names in the sys_vendor and
product_name DMI strings, without this patch brcmfmac will try to load:
brcmfmac43340-sdio.Insyde-BayTrail.txt as nvram file which is a bit
too generic.

Add a DMI quirk so that a unique and clearly identifiable nvram file name
is used on the Acer A1 840 tablet.

Signed-off-by: Hans de Goede <hansg@kernel.org>
---
 .../net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
index c3a602197662..abe7f6501e5e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
@@ -24,6 +24,10 @@ static const struct brcmf_dmi_data acepc_t8_data = {
 	BRCM_CC_4345_CHIP_ID, 6, "acepc-t8"
 };
 
+static const struct brcmf_dmi_data acer_a1_840_data = {
+	BRCM_CC_43340_CHIP_ID, 2, "acer-a1-840"
+};
+
 /* The Chuwi Hi8 Pro uses the same Ampak AP6212 module as the Chuwi Vi8 Plus
  * and the nvram for the Vi8 Plus is already in linux-firmware, so use that.
  */
@@ -91,6 +95,16 @@ static const struct dmi_system_id dmi_platform_data[] = {
 		},
 		.driver_data = (void *)&acepc_t8_data,
 	},
+	{
+		/* Acer Iconia One 8 A1-840 (non FHD version) */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"),
+			/* Above strings are too generic also match BIOS date */
+			DMI_MATCH(DMI_BIOS_DATE, "04/01/2014"),
+		},
+		.driver_data = (void *)&acer_a1_840_data,
+	},
 	{
 		/* Chuwi Hi8 Pro with D2D3_Hi8Pro.233 BIOS */
 		.matches = {
-- 
2.51.0

Re: [PATCH] brcmfmac: Add DMI nvram filename quirk for Acer A1 840 tablet

[Arend van Spriel]

On 10/20/2025 6:34 PM, Hans de Goede wrote:
> The Acer A1 840 tablet contains quite generic names in the sys_vendor and
> product_name DMI strings, without this patch brcmfmac will try to load:
> brcmfmac43340-sdio.Insyde-BayTrail.txt as nvram file which is a bit
> too generic.
> 
> Add a DMI quirk so that a unique and clearly identifiable nvram file name
> is used on the Acer A1 840 tablet.

Thanks, Hans

Please note that the subject should start with subtree name, ie. 'wifi' 
prefixed:

wifi: brcmfmac: Add DMI nvram filename quirk for Acer A1 840 tablet

Apart from that...

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

> Signed-off-by: Hans de Goede <hansg@kernel.org>
> ---
>   .../net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)