From: Johannes Berg <johannes@sipsolutions.net>
To: Daniel Halperin <dhalperi@cs.washington.edu>
Cc: John Linville <linville@tuxdriver.com>,
Emmanuel Grumbach <egrumbach@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: fix comment regarding aggregation buf_size
Date: Wed, 16 Mar 2011 11:09:55 +0100 [thread overview]
Message-ID: <1300270195.3761.18.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTi=r-iktQVn8b1=iCh0PFDDP=mSVBUeqBfxa5e_B@mail.gmail.com>
On Wed, 2011-03-16 at 02:47 -0700, Daniel Halperin wrote:
> <dan starts here>
>
> > + * possible with a buf_size of 8:
> > + * - TX: 1.....7
> > + * - RX: 2.....7 (lost frame #1),
> > + * - TX: 89...1...
> > + * which is invalid since #1 was now re-transmitted well past the
> > + * buffer size of 7. The correct way to retransmit #1 would be:
> > + * - TX: 1 or
> > + * - TX: 18
> > + * though the standard allows:
> > + * - TX: 81
> > + * The following might happen, but will violate buffering assumptions as above if frame 1 is lost again
> > + * - TX: 189.....
Oh, oops, yes you're right. Will respin the patch.
johannes
prev parent reply other threads:[~2011-03-16 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 9:39 [PATCH] mac80211: fix comment regarding aggregation buf_size Johannes Berg
2011-03-16 9:47 ` Daniel Halperin
2011-03-16 9:51 ` Daniel Halperin
2011-03-16 9:55 ` Emmanuel Grumbach
2011-03-16 10:09 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300270195.3761.18.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dhalperi@cs.washington.edu \
--cc=egrumbach@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox