From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: set the actual tid instead of the ac
Date: Mon, 21 Mar 2011 16:24:27 +0200 [thread overview]
Message-ID: <1300717467.2593.213.camel@cumari> (raw)
In-Reply-To: <1300309434-15491-1-git-send-email-eliad@wizery.com>
On Wed, 2011-03-16 at 23:03 +0200, Eliad Peller wrote:
> When passing a tx frame, the driver incorrectly set desc->tid
> with the ac instead of the actual tid.
>
> It has some serious implications when using 802.11n + QoS,
> as the fw starts a BlockAck with the wrong tid (which finally
> cause beacon loss and disconnection / some fw crash)
>
> Fix it by using the actual tid stored in skb->priority.
>
> Reported-by: Shahar Levi <shahar_levi@ti.com>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
Applied, thank you! And thanks Juuso for the review!
--
Cheers,
Luca.
prev parent reply other threads:[~2011-03-21 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 21:03 [PATCH] wl12xx: set the actual tid instead of the ac Eliad Peller
2011-03-17 5:38 ` Juuso Oikarinen
2011-03-21 7:54 ` Eliad Peller
2011-03-21 7:59 ` Juuso Oikarinen
2011-03-21 8:49 ` Juuso Oikarinen
2011-03-21 14:24 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300717467.2593.213.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).