Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: juuso.oikarinen@nokia.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: Fix potential incorrect band in rx-status
Date: Mon, 21 Mar 2011 17:07:26 +0200	[thread overview]
Message-ID: <1300720046.2593.232.camel@cumari> (raw)
In-Reply-To: <1300713823.2593.203.camel@cumari>

On Mon, 2011-03-21 at 15:23 +0200, Luciano Coelho wrote:
> On Thu, 2011-03-10 at 10:01 +0200, juuso.oikarinen@nokia.com wrote:
> > From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> > 
> > The rx-status passed to mac80211 along with each received frame
> > contains the
> > band on which the frame was received. Under certain circumstances,
> > this band
> > information may be incorrect, causing in worst case a WARNING from
> > mac80211,
> > and causes the received frame to be dropped.
> > 
> > This scenario mainly occurs when performing connected-mode scans, when
> > the
> > received scan results are from the other band than the one currentl
> > associated to.
> > 
> > Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com> 
> 
> Looks good, thanks!
> 
> Reviewed-by: Luciano Coelho <coelho@ti.com>
> 
> Applied to wl12xx/master with a small s/currentl/currently/ ;)

Ahm, there was a compilation problem with this on my tree.  The
following line had to be changed as well:

-	status->freq = ieee80211_channel_to_frequency(desc->channel, desc_band);
+	status->freq = ieee80211_channel_to_frequency(desc->channel,
+						      status->band);

Fixed the patch and reapplied.

-- 
Cheers,
Luca.


      reply	other threads:[~2011-03-21 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10  8:01 [PATCH] wl12xx: Fix potential incorrect band in rx-status juuso.oikarinen
2011-03-21 13:23 ` Luciano Coelho
2011-03-21 15:07   ` Luciano Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300720046.2593.232.camel@cumari \
    --to=coelho@ti.com \
    --cc=juuso.oikarinen@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox