From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
To: ext Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: fix BSS double-unlinking (continued)
Date: Mon, 28 Mar 2011 14:04:34 +0300 [thread overview]
Message-ID: <1301310274.30578.0.camel@wimaxnb.nmp.nokia.com> (raw)
In-Reply-To: <1301309825.3850.3.camel@jlt3.sipsolutions.net>
On Mon, 2011-03-28 at 12:57 +0200, ext Johannes Berg wrote:
> On Mon, 2011-03-28 at 10:11 +0300, juuso.oikarinen@nokia.com wrote:
> > From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> >
> > This patch adds to the fix "fix BSS double-unlinking"
> > (commit 3207390a8b58bfc1335750f91cf6783c48ca19ca) by Johannes Berg.
> >
> > It turns out, that the double-unlinking scenario can also occur if expired
> > BSS elements are removed whilst an interface is performing association.
>
> Ack,
>
> > To work around that, replace list_del with list_del_init also in the
> > "cfg80211_bss_expire" function, so that the check for whether the BSS still is
> > in the list works correctly in cfg80211_bss_expire.
>
> but I think you mean cfg80211_unlink_bss there at the end.
Yeah, right.
> Might be worthwhile to create a new static function that rolls up this
> code (list_del_init, rb_erase, kref_put) between the two functions?
Sure, can do.
-Juuso
prev parent reply other threads:[~2011-03-28 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 7:11 [PATCH] cfg80211: fix BSS double-unlinking (continued) juuso.oikarinen
2011-03-28 10:57 ` Johannes Berg
2011-03-28 11:04 ` Juuso Oikarinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301310274.30578.0.camel@wimaxnb.nmp.nokia.com \
--to=juuso.oikarinen@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox