From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlegacy: fix bugs in change_interface
Date: Tue, 29 Mar 2011 15:26:15 +0200 [thread overview]
Message-ID: <1301405175.3834.15.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110329132231.GA6919@redhat.com>
On Tue, 2011-03-29 at 15:22 +0200, Stanislaw Gruszka wrote:
> On Tue, Mar 29, 2011 at 02:05:59PM +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > If change_interface gets invoked during a firmware
> > restart, it may crash; prevent that from happening
> > by checking if ctx->vif is assigned.
> >
> > Additionally, in my initial commit I forgot to set
> > the vif->p2p variable correctly, so fix that too,
> > even if it doesn't matter since P2P isn't supported.
>
> ACK
>
> Does we also need iwl_{legacy,}is_ready_rf check?
Good question, I guess it wouldn't hurt.
FWIW, I'm submitting the iwlagn version (which looks just the same) to
our own testing first.
johannes
next prev parent reply other threads:[~2011-03-29 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 12:05 [PATCH] iwlegacy: fix bugs in change_interface Johannes Berg
2011-03-29 13:22 ` Stanislaw Gruszka
2011-03-29 13:26 ` Johannes Berg [this message]
2011-03-29 13:28 ` [PATCH v2] " Johannes Berg
2011-03-29 14:28 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301405175.3834.15.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).