From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: rearrange some ELP wake_up/sleep calls
Date: Fri, 01 Apr 2011 10:53:59 +0300 [thread overview]
Message-ID: <1301644439.1988.412.camel@cumari> (raw)
In-Reply-To: <1300911735-27655-1-git-send-email-eliad@wizery.com>
On Wed, 2011-03-23 at 22:22 +0200, Eliad Peller wrote:
> ELP (Extremely/Enhanced Low Power, or something like that ;)) refers to
> the powerstate of the 12xx chip, in which very low power is consumed,
> and no commands (from the host) can be issued until the chip is woken up.
>
> Wakeup/sleep commands must be protected by a wl->mutex, so it's generally
> a good idea to call wakeup/sleep along with the mutex lock/unlock (where
> needed). However, in some places the wl12xx driver calls wakeup/sleep in
> some "inner" functions. This result in some "nested" wakeup/sleep calls
> which might end up letting the chip go to sleep prematurely (e.g. during
> event handling).
>
> Fix it by rearranging the elp calls to come along with mutex_lock/unlock.
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> Signed-off-by: Ido Yariv <ido@wizery.com>
> ---
Applied, thanks!
--
Cheers,
Luca.
prev parent reply other threads:[~2011-04-01 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 20:22 [PATCH] wl12xx: rearrange some ELP wake_up/sleep calls Eliad Peller
2011-04-01 7:53 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301644439.1988.412.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox