Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: Ido Yariv <ido@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/5] wl12xx: Clean up the block size alignment code
Date: Fri, 01 Apr 2011 14:23:49 +0300	[thread overview]
Message-ID: <1301657029.1988.478.camel@cumari> (raw)
In-Reply-To: <1301558821-17787-3-git-send-email-ido@wizery.com>

On Thu, 2011-03-31 at 10:06 +0200, Ido Yariv wrote:
> Simplify and clean up the block size alignment code:
> 1. Set the block size according to the padding field type, as it cannot
>    exceed the maximum value this field can hold.
> 2. Move the alignment code into a function instead of duplicating it in
>    multiple places.
> 3. In the current implementation, the block_size member can be
>    misleading because a zero value actually means that there's no need to
>    align. Declare a block size alignment quirk instead.
> 
> Signed-off-by: Ido Yariv <ido@wizery.com>
> ---

Applied, thanks!

-- 
Cheers,
Luca.


  reply	other threads:[~2011-04-01 11:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31  8:06 [PATCH 0/5] wl12xx: Cleanups & fixes Ido Yariv
2011-03-31  8:06 ` [PATCH 1/5] wl12xx: Clean up and fix the 128x boot sequence Ido Yariv
2011-04-01 10:43   ` Luciano Coelho
2011-03-31  8:06 ` [PATCH 2/5] wl12xx: Clean up the block size alignment code Ido Yariv
2011-04-01 11:23   ` Luciano Coelho [this message]
2011-03-31  8:06 ` [PATCH 3/5] wl12xx: Clean up the dummy packet mechanism Ido Yariv
2011-03-31  8:07 ` [PATCH 4/5] wl12xx: Simplify TX blocks accounting Ido Yariv
2011-03-31  8:07 ` [PATCH 5/5] wl12xx: Handle platforms without level trigger interrupts Ido Yariv
2011-04-01 11:30 ` [PATCH 0/5] wl12xx: Cleanups & fixes Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301657029.1988.478.camel@cumari \
    --to=coelho@ti.com \
    --cc=ido@wizery.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox