From: Johannes Berg <johannes@sipsolutions.net>
To: Vivek Natarajan <vnatarajan@atheros.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] mac80211: Check for queued frames before entering power save.
Date: Fri, 01 Apr 2011 13:51:45 +0200 [thread overview]
Message-ID: <1301658705.3832.21.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1301658324-11530-1-git-send-email-vnatarajan@atheros.com>
On Fri, 2011-04-01 at 17:15 +0530, Vivek Natarajan wrote:
> In a highly noisy environment, since the driver could not send
> the packets out in 100ms, some applications stall and eventually
> fail as mac80211 stops the netdevice queues for flush when power
> save is triggered. Most of the WMM testcases fail in the Wifi
> testing because of this.
> Increasing the dynamic ps timeout to 200-300ms helps but in noisy
> channel conditions even if there is a continuous tx traffic, mac80211
> tries to go into PS. The new implementation checks for any frames
> queued in the driver tx queues and based on that mac80211 decides
> to go for power save. This also prevents redundant stopping of
> netdevice queues which helps more applications to run properly.
I think as an API change this needs more justification. Why does this
need a new callback, for example?
johannes
next prev parent reply other threads:[~2011-04-01 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 11:45 [RFC PATCH 1/2] mac80211: Check for queued frames before entering power save Vivek Natarajan
2011-04-01 11:45 ` [RFC PATCH 2/2] ath9k: Implement dev_tx_frames_pending callback Vivek Natarajan
2011-04-01 11:51 ` Johannes Berg [this message]
2011-04-01 12:12 ` [RFC PATCH 1/2] mac80211: Check for queued frames before entering power save Vivek Natarajan
2011-04-07 10:33 ` Johannes Berg
2011-04-07 11:47 ` Vivek Natarajan
2011-04-07 11:51 ` Johannes Berg
2011-04-07 12:04 ` Vivek Natarajan
2011-04-11 14:17 ` Vivek Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301658705.3832.21.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vnatarajan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).