Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2.6.40] wl12xx: fix potential buffer overflow in testmode nvs push
Date: Fri, 01 Apr 2011 19:48:14 +0300	[thread overview]
Message-ID: <1301676494.1988.492.camel@cumari> (raw)
In-Reply-To: <1301676400-4912-1-git-send-email-coelho@ti.com>

On Fri, 2011-04-01 at 19:46 +0300, Luciano Coelho wrote:
> We were allocating the size of the NVS file according to the chip ID
> and not checking whether the length of the buffer passed was correct
> before copying it into the allocated memory.  This is a security hole
> because buffer overflows can occur if the userspace passes a bigger
> file than what is expected.
> 
> With this patch, we check if the size of the data passed from
> userspace matches the size required by the chip.
> 
> Reported-by: Ido Yariv <ido@wizery.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> ---

I'll merge this change so that it fits with the one I sent for 2.6.39
and stable, when time comes.  For now, we don't want things overflowing
in the wl12xx.git tree either, so fix it there too. ;)

-- 
Cheers,
Luca.


      reply	other threads:[~2011-04-01 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-01 16:46 [PATCH 2.6.40] wl12xx: fix potential buffer overflow in testmode nvs push Luciano Coelho
2011-04-01 16:48 ` Luciano Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301676494.1988.492.camel@cumari \
    --to=coelho@ti.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox