From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Marc Yang <yangyang@marvell.com>,
Frank Huang <frankh@marvell.com>, Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH 1/2] mwifiex: return success in set_default_key for WPA/WPA2
Date: Sun, 03 Apr 2011 10:02:55 +0200 [thread overview]
Message-ID: <1301817775.3984.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1301708207-16265-1-git-send-email-bzhao@marvell.com>
On Fri, 2011-04-01 at 18:36 -0700, Bing Zhao wrote:
> From: Amitkumar Karwar <akarwar@marvell.com>
>
> When testing wpa_supplicant with 'nl80211' driver to connect
> to an AP with WPA/WPA2 security, we notice the followings:
>
> 1) add_key is called firstly with the key from cfg80211
> 2) set_defaut_key is called next
>
> set_default_key() is specific to WEP keys and should not be
> called in case of WPA/WPA2 security. The set_default_key()
> won't be called if wpa_supplicant uses "-Dwext" option,
> but it's been called if "-Dnl80211" option is specified.
>
> We can fix this issue by adding a check to return from
> set_default_key() if WEP key is not configured.
Hmmm. Yeah this seems like it shouldn't be happening, but maybe checking
should be in cfg80211 and it should reject the supplicant's call?
johannes
next prev parent reply other threads:[~2011-04-03 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 1:36 [PATCH 1/2] mwifiex: return success in set_default_key for WPA/WPA2 Bing Zhao
2011-04-02 1:36 ` [PATCH 2/2] mwifiex: remove redundant encryption_mode mapping Bing Zhao
2011-04-03 8:02 ` Johannes Berg [this message]
2011-04-03 8:37 ` [PATCH 1/2] mwifiex: return success in set_default_key for WPA/WPA2 Johannes Berg
2011-04-05 18:45 ` Bing Zhao
2011-04-05 18:53 ` Johannes Berg
2011-04-05 23:22 ` Bing Zhao
2011-04-06 7:08 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301817775.3984.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yangyang@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).