From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, javier@cozybit.com,
linville@tuxdriver.com
Subject: Re: [PATCH v6 00/10] {mac|nl}80211: mesh security enhancements
Date: Mon, 04 Apr 2011 22:44:04 +0200 [thread overview]
Message-ID: <1301949844.3795.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <BANLkTim8wWf08fqRzG3F9KfMiq0WGzq0WQ@mail.gmail.com>
On Mon, 2011-04-04 at 13:38 -0700, Thomas Pedersen wrote:
> > I don't believe this patchset works, since mac80211 doesn't set
> > @WIPHY_FLAG_MESH_AUTH afaict.
> >
>
> in patch 10/10:
> diff --git a/net/mac80211/main.c b/net/mac80211/main.c
> index 0ae9b22..55cc521 100644
> --- a/net/mac80211/main.c
> +++ b/net/mac80211/main.c
> @@ -761,6 +761,10 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
> /* mesh depends on Kconfig, but drivers should set it if they want */
> local->hw.wiphy->interface_modes &= ~BIT(NL80211_IFTYPE_MESH_POINT);
> #endif
> + /* if the underlying driver supports mesh, mac80211 will (at least)
> + * provide routing of mesh authentication frames to userspace */
> + if (local->hw.wiphy->interface_modes & BIT(NL80211_IFTYPE_MESH_POINT))
> + local->hw.wiphy->flags |= WIPHY_FLAG_MESH_AUTH;
Ah, well, clearly that shouldn't be in an nl80211 patch :-)
johannes
prev parent reply other threads:[~2011-04-04 20:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 20:35 [PATCH v6 00/10] {mac|nl}80211: mesh security enhancements Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 01/10] nl80211: rename NL80211_MESH_SETUP_VENDOR_PATH_SEL_IE Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 02/10] nl80211: Add userspace authentication flag to mesh setup Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 03/10] mac80211: ignore peers if security is enabled for this mesh Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 04/10] nl80211: let userspace authenticate stations Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 05/10] mac80211: Let user space receive and send mesh auth/deauth frames Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 06/10] mac80211: ignore peer link requests from unauthenticated stations Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 07/10] mac80211: Perform PLINK_ACTION on new station Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 08/10] nl80211: New notification to discover mesh peer candidates Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 09/10] mac80211: send notification on new peer candidate for our secure mesh Thomas Pedersen
2011-04-01 20:35 ` [PATCH v6 10/10] nl80211: report mesh capabilities Thomas Pedersen
2011-04-04 12:20 ` Johannes Berg
2011-04-04 12:21 ` [PATCH v6 00/10] {mac|nl}80211: mesh security enhancements Johannes Berg
2011-04-04 20:38 ` Thomas Pedersen
2011-04-04 20:44 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301949844.3795.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).