RE: [PATCH 1/2] mwifiex: return success in set_default_key for WPA/WPA2

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2011-04-05 at 16:22 -0700, Bing Zhao wrote:

> > > WPA: Installing PTK to the driver.
> > > WPA: RSC - hexdump(len=6): 00 00 00 00 00 00
> > > wpa_driver_nl80211_set_key: ifindex=12 alg=2 addr=0x80a7168 key_idx=0 set_tx=1 seq_len=6 key_len=32
> > >    addr=00:1b:2f:55:79:7e

> > What happens if you just reject the set_default_key and return -EINVAL
> > instead of 0?
> 
> wpa_supplicant disconnects if we return -EINVAL in set_default_key handler.
> 
> WPA: Installing PTK to the driver.
> WPA: RSC - hexdump(len=6): 00 00 00 00 00 00
> wpa_driver_nl80211_set_key: ifindex=3 alg=2 addr=0x9f6eef8 key_idx=0 set_tx=1 seq_len=6 key_len=32
>    addr=00:50:43:21:07:f8
> nl80211: set_key default failed; err=-22 Invalid argument)
> WPA: Failed to set PTK to the driver (alg=2 keylen=32 bssid=00:50:43:21:07:f8)
> wpa_driver_nl80211_disconnect

Ok. In the meantime, Jouni kinda convinced me that returning 0 is fine
since we only ever TX to the AP, and that key will already be used for
that, so let's go with the patch for now -- I'd still like to figure out
why wpa_s is even requesting this, but that doesn't need to be on you.

johannes