From: Johannes Berg <johannes@sipsolutions.net>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] mac80211: Check for queued frames before entering power save.
Date: Thu, 07 Apr 2011 13:51:21 +0200 [thread overview]
Message-ID: <1302177081.3779.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <BANLkTimNaaUyJ2jKG1gZ3WeWPA9E25y3pw@mail.gmail.com>
On Thu, 2011-04-07 at 17:17 +0530, Vivek Natarajan wrote:
> > I'm not sure I understand. Where does the 100ms come from? This code
> > flushes the TX queues, which can take as much time as it wants, no? How
> > does it break applications?
>
> 100ms is the time after which the dynamic ps timer stops the netif
> queues and flushes all the frames in the driver. Actually two factors
> caused the application to timeout:
> One is the delay in the flush() for which the netif queues are
> stopped and eventually the application could not send out the frames.
> The second is the dropping of frames in the flush() callback when it
> reaches the timeout period.
Is that an ath9k specific thing? mac80211 never invokes flush() with
drop=true, at this point. I thought we needed it and added it, but I
guess we don't really need it.
johannes
next prev parent reply other threads:[~2011-04-07 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 11:45 [RFC PATCH 1/2] mac80211: Check for queued frames before entering power save Vivek Natarajan
2011-04-01 11:45 ` [RFC PATCH 2/2] ath9k: Implement dev_tx_frames_pending callback Vivek Natarajan
2011-04-01 11:51 ` [RFC PATCH 1/2] mac80211: Check for queued frames before entering power save Johannes Berg
2011-04-01 12:12 ` Vivek Natarajan
2011-04-07 10:33 ` Johannes Berg
2011-04-07 11:47 ` Vivek Natarajan
2011-04-07 11:51 ` Johannes Berg [this message]
2011-04-07 12:04 ` Vivek Natarajan
2011-04-11 14:17 ` Vivek Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302177081.3779.11.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).