From: Johannes Berg <johannes@sipsolutions.net>
To: Anantha Idapalapati <aidapalapati@nvidia.com>
Cc: "olofj@chromium.org" <olofj@chromium.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
Uday Raval <uraval@nvidia.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Andy Ritger <ARitger@nvidia.com>,
Rakesh Kumar <krakesh@nvidia.com>
Subject: RE: [PATCH] CHROMIUM: config: bluetooth: rfkill driver
Date: Mon, 11 Apr 2011 16:53:49 +0200 [thread overview]
Message-ID: <1302533629.6487.14.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <108BD5B22FBF9E46BD793DEDBF92B7056CF1A54FD2@BGMAIL02.nvidia.com>
On Mon, 2011-04-11 at 20:15 +0530, Anantha Idapalapati wrote:
> Initially it was written specific to BCM4329. But because of the
> reason most of the BT chips have similar switch on/off sequence, this
> driver is made generic. If there is any specific changes required for
> a particular platform, this driver can be taken as reference.
Well, so, it still has bcm4329 all over the code, so you should get rid
of that and just call it rfkill_gpio or something. Also, if it's all
this generic, then how about you make an rfkill GPIO driver that works
like the rfkill regulator driver we recently got?
johannes
next prev parent reply other threads:[~2011-04-11 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 14:33 [PATCH] CHROMIUM: config: bluetooth: rfkill driver aidapalapati
2011-04-11 14:38 ` Johannes Berg
2011-04-11 14:45 ` Anantha Idapalapati
2011-04-11 14:53 ` Johannes Berg [this message]
2011-04-11 15:21 ` Olof Johansson
2011-04-12 11:29 ` Anantha Idapalapati
-- strict thread matches above, loose matches on Subject: below --
2011-04-12 11:25 aidapalapati
2011-04-12 11:42 ` Johannes Berg
2011-04-12 14:19 ` Anantha Idapalapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302533629.6487.14.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ARitger@nvidia.com \
--cc=aidapalapati@nvidia.com \
--cc=krakesh@nvidia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=olofj@chromium.org \
--cc=uraval@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox