From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:15096 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754849Ab1DKSmD (ORCPT ); Mon, 11 Apr 2011 14:42:03 -0400 Subject: Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY From: wwguy To: "John W. Linville" Cc: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dave Airlie , Stanislaw Gruszka In-Reply-To: <1302541599-15383-1-git-send-email-linville@tuxdriver.com> References: <1302541599-15383-1-git-send-email-linville@tuxdriver.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 11 Apr 2011 11:39:22 -0700 Message-ID: <1302547162.5663.2.camel@wwguy-ubuntu> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2011-04-11 at 10:06 -0700, John W. Linville wrote: > Otherwise, IWLWIFI_LEGACY has to be selected independently before the > drivers are made available. > > Reported-by: Dave Airlie > Signed-off-by: John W. Linville > Cc: Stanislaw Gruszka > Cc: Wey-Yi Guy > --- > drivers/net/wireless/iwlegacy/Kconfig | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig > index 2a45dd4..aef65cd 100644 > --- a/drivers/net/wireless/iwlegacy/Kconfig > +++ b/drivers/net/wireless/iwlegacy/Kconfig > @@ -1,6 +1,5 @@ > config IWLWIFI_LEGACY > - tristate "Intel Wireless Wifi legacy devices" > - depends on PCI && MAC80211 > + tristate > select FW_LOADER > select NEW_LEDS > select LEDS_CLASS Should we add some ---help--- here?, or not.. Wey