From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>
Subject: Re: [PATCH 1/2] mac80211: allow low level drivers to report packet loss
Date: Mon, 18 Apr 2011 14:26:50 +0200 [thread overview]
Message-ID: <1303129610.3588.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1303125749-31967-1-git-send-email-arik@wizery.com>
On Mon, 2011-04-18 at 14:22 +0300, Arik Nemtsov wrote:
> Add API that allows low level drivers to notify mac80211 about TX
> packet loss. This is useful when there are FW triggers to notify the
> low level driver about these events.
> +void ieee80211_report_low_ack(struct ieee80211_sta *pubsta, u32 num_packets)
> +{
> + struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
> + cfg80211_cqm_pktloss_notify(sta->sdata->dev, sta->sta.addr,
> + num_packets, GFP_ATOMIC);
I think it would make more sense to add num_packets to sta->lost_packets
and invoke it only when over the threshold as done in
ieee80211_tx_status(), as then we can share any threshold calculation
improvements.
Also, are you sure? Do you really not get _any_ TX status?
johannes
next prev parent reply other threads:[~2011-04-18 12:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 11:22 [PATCH 1/2] mac80211: allow low level drivers to report packet loss Arik Nemtsov
2011-04-18 11:22 ` [PATCH 2/2] wl12xx: support FW TX inactivity triggers Arik Nemtsov
2011-04-26 5:02 ` Arik Nemtsov
2011-04-18 12:26 ` Johannes Berg [this message]
2011-04-18 20:44 ` [PATCH 1/2] mac80211: allow low level drivers to report packet loss Arik Nemtsov
2011-04-19 12:36 ` Johannes Berg
2011-04-19 21:54 ` Arik Nemtsov
2011-04-20 8:08 ` Johannes Berg
2011-04-26 19:12 ` John W. Linville
2011-04-26 19:35 ` Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303129610.3588.7.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).