From: Luciano Coelho <coelho@ti.com>
To: Guy Eilam <guy@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: use 2 spare TX blocks for GEM cipher
Date: Tue, 19 Apr 2011 14:55:05 +0300 [thread overview]
Message-ID: <1303214105.1988.679.camel@cumari> (raw)
In-Reply-To: <BANLkTimtZaGTcouKvKS+cEfU=G6c6b775w@mail.gmail.com>
On Tue, 2011-04-12 at 08:03 +0300, Guy Eilam wrote:
> On Fri, Apr 8, 2011 at 8:38 PM, Luciano Coelho <coelho@ti.com> wrote:
> > On Sun, 2011-04-03 at 15:37 +0300, Guy Eilam wrote:
> >> diff --git a/drivers/net/wireless/wl12xx/tx.c b/drivers/net/wireless/wl12xx/tx.c
> >> index db9e47e..2c79b6e 100644
> >> --- a/drivers/net/wireless/wl12xx/tx.c
> >> +++ b/drivers/net/wireless/wl12xx/tx.c
> >> @@ -135,12 +135,10 @@ static int wl1271_tx_allocate(struct wl1271 *wl, struct sk_buff *skb, u32 extra,
> >> u32 len;
> >> u32 total_blocks;
> >> int id, ret = -EBUSY;
> >> - u32 spare_blocks;
> >> + u32 spare_blocks = wl->tx_spare_blocks;
> >>
> >> if (unlikely(wl->quirks & WL12XX_QUIRK_USE_2_SPARE_BLOCKS))
> >> spare_blocks = 2;
> >> - else
> >> - spare_blocks = 1;
> >
> > Do we still need the quirk now? Wouldn't it be nicer to change the
> > wl->tx_spare_blocks value directly instead?
> >
>
> We still need the quirk because if we change the tx_spare_blocks
> directly, then the
> we also need to have a tx_spare_blocks_previously member so that the KEY_GEM
> code will know the value to set in KEY_REMOVAL.
> Do you really think that it is better?
No, indeed this sounds more complicated, so you can keep it as it is.
--
Cheers,
Luca.
prev parent reply other threads:[~2011-04-19 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 12:37 [PATCH] wl12xx: use 2 spare TX blocks for GEM cipher Guy Eilam
2011-04-08 17:38 ` Luciano Coelho
2011-04-12 5:03 ` Guy Eilam
2011-04-19 11:55 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303214105.1988.679.camel@cumari \
--to=coelho@ti.com \
--cc=guy@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox