From: "Michael Büsch" <m@bues.ch>
To: Roland Vossen <rvossen@broadcom.com>
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 1/2] staging: brcm80211: removed #ifdef __mips__
Date: Tue, 19 Apr 2011 14:10:02 +0200 [thread overview]
Message-ID: <1303215002.27432.5.camel@maggie> (raw)
In-Reply-To: <1303197225-4263-2-git-send-email-rvossen@broadcom.com>
On Tue, 2011-04-19 at 09:13 +0200, Roland Vossen wrote:
> Code cleanup. __mips__ was undefined for current builds.
>
> Signed-off-by: Roland Vossen <rvossen@broadcom.com>
> Reviewed-by: Arend van Spriel <arend@broadcom.com>
> ---
> .../staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c | 48 --------------------
> drivers/staging/brcm80211/include/bcmdefs.h | 4 --
> drivers/staging/brcm80211/include/bcmutils.h | 31 -------------
> drivers/staging/brcm80211/util/bcmutils.c | 28 -----------
> drivers/staging/brcm80211/util/hnddma.c | 23 ---------
> 5 files changed, 0 insertions(+), 134 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c b/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c
> index 40f0444..92133c7 100644
> --- a/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c
> +++ b/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c
> @@ -246,15 +246,9 @@ u16 read_radio_reg(phy_info_t *pi, u16 addr)
> (D11REV_IS(pi->sh->corerev, 22)
> && (pi->pubpi.phy_type != PHY_TYPE_SSN))) {
> W_REG(&pi->regs->radioregaddr, addr);
> -#ifdef __mips__
> - (void)R_REG(&pi->regs->radioregaddr);
> -#endif
Are you sure? __mips__ is automagically defined by GCC, if compiling
for MIPS. Maybe it should be converted to some CONFIG_... symbol.
But removal seems wrong.
--
Greetings Michael.
next prev parent reply other threads:[~2011-04-19 12:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 7:13 [PATCH 0/2] staging: brcm80211: removal of obsolete mips code Roland Vossen
2011-04-19 7:13 ` [PATCH 1/2] staging: brcm80211: removed #ifdef __mips__ Roland Vossen
2011-04-19 12:10 ` Michael Büsch [this message]
2011-04-19 13:45 ` Roland Vossen
2011-04-19 13:49 ` Michael Büsch
2011-04-19 13:57 ` Johannes Berg
2011-04-20 7:40 ` Roland Vossen
2011-04-19 7:13 ` [PATCH 2/2] staging: brcm80211: removed BCMFASTPATH macro Roland Vossen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303215002.27432.5.camel@maggie \
--to=m@bues.ch \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).