Re: [PATCH 03/10] iwlagn: verify that huge commands are synchronous

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2011-04-19 at 14:03 +0200, Stanislaw Gruszka wrote:
> On Mon, Apr 18, 2011 at 09:44:10AM -0700, Wey-Yi Guy wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> > 
> > Since huge commands all share a single buffer,
> > there can only be a single one in flight at a
> > time since otherwise they'd overwrite each
> > other. This is true in the driver now, but it
> > seems like a possible source of bugs, so add
> > a test to verify that huge commands are always
> > sent synchronously.
> 
> I belive WARN_ON(out_meta->flags & CMD_MAPPED) I added, protect from
> overwite huge commands buffer already.

Yup, that's (almost) true. I wrote this patch before yours were merged,
they just crossed in our tree.

With only your patch though an asynchronous HUGE command can still
succeed, unless there are two at the same time. Mine makes it always
warn and fail, which is what we want, because otherwise you might not
notice right away that it could clash.

johannes