From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: avoid redundant join on interface reconfiguration
Date: Wed, 20 Apr 2011 21:05:34 +0300 [thread overview]
Message-ID: <1303322734.1988.740.camel@cumari> (raw)
In-Reply-To: <1302020008-28018-1-git-send-email-eliad@wizery.com>
On Tue, 2011-04-05 at 19:13 +0300, Eliad Peller wrote:
> ieee80211_reconfig() sets most of the "changed" flags regardless
> of the actual change (e.g. BSS_CHANGED_ASSOC will be set even if
> the interface is still not associated). in this case the driver
> will issue some unneeded commands.
>
> Since the driver relies solely on the BSS_CHANGED_ASSOC flag,
> without checking if there was an actual change, it will end up
> issuing unjoin() and dummy_join() commands, although it was
> never associated and should just remain idle.
>
> Avoid it by checking the actual state change, in addition to the
> "changed" flag.
>
> (there seem to be more redundant configuration commands being
> issued, but they shouldn't harm)
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
Indeed, I have seen similar assumptions in the driver that caused
problems. Thanks for the fix.
Applied.
--
Cheers,
Luca.
prev parent reply other threads:[~2011-04-20 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 16:13 [PATCH] wl12xx: avoid redundant join on interface reconfiguration Eliad Peller
2011-04-20 18:05 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303322734.1988.740.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox