Re: [PATCH 1/1 RFC] mac80211: add ratio to led blinking trigger

[Johannes Berg <johannes@sipsolutions.net>]

On Sun, 2011-04-24 at 11:48 -0700, wwguy wrote:
> On Sun, 2011-04-24 at 11:38 -0700, Johannes Berg wrote:
> > On Sun, 2011-04-24 at 10:15 -0700, Wey-Yi Guy wrote:
> > > The current led blink trigger implementaion assume on/off time are equal,
> > > it works but not have any flexbile for different blink pattern.
> > > 
> > > Add "ratio" parameter in the trigger table and give driver more control
> > > on how the on/off blink time behavior should be.
> > 
> > I considered this when writing the original code, but then decided that
> > nobody needed to have unequal on/off times. Why would we need it now?
> > (FWIW, blink = 0 is always on already, no?)
> > 
> But from what I read for iwlwifi, to turn LED_SOLID_ON, on = 11, off =
> 0. Did I read it wrong.

Ah, well, mac80211 has:

        /* default to just solid on */
        on = 1;
        off = 0;

So if you want "solid on" by default for 0 tpt, you simply don't specify
the -1 value, ie. just remove the -1 line from the table completely.
IOW, instead of the patch you posted before, a simple patch just
removing the first line from the table should be sufficient.

> Yes, I agree as today, "on" == "off", just thinking we should make more
> flexible.

I just don't see the point since we don't really need it.

johannes