Re: [PATCH V2 1/2] wl12xx: consider encryption when configuring auto arp template

[Luciano Coelho <coelho@ti.com>]

On Tue, 2011-04-26 at 11:39 +0300, Eliad Peller wrote:
> >> @@ -2749,8 +2764,10 @@ static void
> wl1271_bss_info_changed_sta(struct wl1271 *wl,
> >>                       ret = wl1271_acx_arp_ip_filter(wl,
> >>                               ACX_ARP_FILTER_ARP_FILTERING,
> >>                               addr);
> >> -             } else
> >> +             } else {
> >> +                     wl->ip_addr = 0;
> >>                       ret = wl1271_acx_arp_ip_filter(wl, 0, addr);
> >> +             }
> >
> > This is not important at all, but maybe it's a bit cleaner: you
> could
> > remove the addr argument in wl1271_acx_arp_ip_filter() and always
> use
> > wl->ip_addr instead? You could then also get rid of the local addr
> here.
> >
> in fact, since we are going toward multi-role fw, i do try to avoid
> using the global wl struct as much as possible.
> anyway, i didn't change this function, so i don't think it's the right
> patch to change it.
> (we should probably change a lot of functions after we'll have a
> per-interface data) 

Agreed. :)

-- 
Cheers,
Luca.