linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ipw3945-devel@lists.sourceforge.net"
	<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2.6.39 v2] iwlegacy: led stay solid on when no traffic
Date: Tue, 26 Apr 2011 12:10:11 -0700	[thread overview]
Message-ID: <1303845011.14995.204.camel@wwguy-huron> (raw)
In-Reply-To: <20110426190816.GH2804@tuxdriver.com>

On Tue, 2011-04-26 at 12:08 -0700, John W. Linville wrote:
> On Mon, Apr 25, 2011 at 11:12:57AM -0700, Wey-Yi Guy wrote:
> > commit 843f26f06a41c5797f19e843c23ca4ed2a71a0bc change the led behavior
> > for iwlwifi driver; the side effect cause led blink all the time.
> > 
> > Modify the led blink table to fix this problem
> > 
> > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> 
> Patch seems fine, but I can't find the listed commit ID that caused this issue?
> 
it is in wireless-testing


commit 843f26f06a41c5797f19e843c23ca4ed2a71a0bc
Author: Johannes Berg <johannes.berg@intel.com>
Date:   Wed Dec 15 07:30:01 2010 -0800

    iwlwifi: use mac80211 throughput trigger
    
    Instead of keeping track of LED blink speed
    in the driver, use the new mac80211 trigger
    and link it up with an LED classdev that we
    now register. This also allows users more
    flexibility in how they want to have the LED
    blink or not.
    
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>



for wireless-next-2.6, it is
commit#commit 5ed540aecc2aae92d5c97b9a9306a5bf88ad5574


Thanks
Wey



  reply	other threads:[~2011-04-26 19:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 18:12 [PATCH 2.6.39 v2] iwlegacy: led stay solid on when no traffic Wey-Yi Guy
2011-04-26 19:08 ` John W. Linville
2011-04-26 19:10   ` Guy, Wey-Yi [this message]
2011-04-26 20:27     ` John W. Linville
2011-04-26 20:22       ` Guy, Wey-Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303845011.14995.204.camel@wwguy-huron \
    --to=wey-yi.w.guy@intel.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).