From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga02.intel.com ([134.134.136.20]:57914 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753747Ab1DZTcj (ORCPT ); Tue, 26 Apr 2011 15:32:39 -0400 Subject: Re: [PATCH 2.6.39 v2] iwlegacy: led stay solid on when no traffic From: "Guy, Wey-Yi" To: "John W. Linville" Cc: "linux-wireless@vger.kernel.org" , "ipw3945-devel@lists.sourceforge.net" In-Reply-To: <20110426190816.GH2804@tuxdriver.com> References: <1303755177-28781-1-git-send-email-wey-yi.w.guy@intel.com> <20110426190816.GH2804@tuxdriver.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 26 Apr 2011 12:10:11 -0700 Message-ID: <1303845011.14995.204.camel@wwguy-huron> (sfid-20110426_213242_731708_833A6D21) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2011-04-26 at 12:08 -0700, John W. Linville wrote: > On Mon, Apr 25, 2011 at 11:12:57AM -0700, Wey-Yi Guy wrote: > > commit 843f26f06a41c5797f19e843c23ca4ed2a71a0bc change the led behavior > > for iwlwifi driver; the side effect cause led blink all the time. > > > > Modify the led blink table to fix this problem > > > > Signed-off-by: Wey-Yi Guy > > Patch seems fine, but I can't find the listed commit ID that caused this issue? > it is in wireless-testing commit 843f26f06a41c5797f19e843c23ca4ed2a71a0bc Author: Johannes Berg Date: Wed Dec 15 07:30:01 2010 -0800 iwlwifi: use mac80211 throughput trigger Instead of keeping track of LED blink speed in the driver, use the new mac80211 trigger and link it up with an LED classdev that we now register. This also allows users more flexibility in how they want to have the LED blink or not. Signed-off-by: Johannes Berg Signed-off-by: Wey-Yi Guy for wireless-next-2.6, it is commit#commit 5ed540aecc2aae92d5c97b9a9306a5bf88ad5574 Thanks Wey