Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Arik Nemtsov <arik@wizery.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wl12xx: support FW TX inactivity triggers
Date: Mon, 02 May 2011 17:51:18 +0300	[thread overview]
Message-ID: <1304347878.12586.256.camel@cumari> (raw)
In-Reply-To: <20110502143757.GD2544@tuxdriver.com>

On Mon, 2011-05-02 at 10:37 -0400, John W. Linville wrote:
> On Mon, May 02, 2011 at 12:50:55PM +0300, Luciano Coelho wrote:
> > Hi John and Arik,
> > 
> > On Sat, 2011-04-30 at 00:09 +0300, Arik Nemtsov wrote:
> > > Hey John,
> > > 
> > > Looking at the latest git, it seems you've picked up this patch
> > > (commit 47684808fd89d6809c0886e06f8ac324252499d8).
> > > This is unfortunate, since there's currently a FW bug that will cause
> > > many disconnections in STA mode with this patch.
> > > 
> > > How would we go about reverting this?
> > 
> > I have reverted this patch in the wl12xx.git tree.  This required a bit
> > of merging and we needed the revert in order to proceed with our tests.
> > 
> > So, John, please don't revert this in your tree.  My revert will come in
> > my next pull-request which will come in a couple of days, after our
> > internal test round is done.
> > 
> > Thanks!
> 
> OK, sounds good.  FWIW, this is what I meant when I said "Do the
> wl12xx guys still want this?"  Granted, that was about the other
> patch in the series, but I kinda presumed that they were related...

Yes, no problem.  I agree that sometimes it makes more sense to apply
this kind of patches together (as you did), especially when both patches
were sent as part of the same series.

The mac80211 part is ready and we thought the wl12xx was good too, but
our internal tests have shown that there are still some problems with
this in our driver, which was decreasing connection stability in
general, thus we wanted this to get reverted.  So, you didn't to
anything wrong (obviously, it was our own fault. ;)

-- 
Cheers,
Luca.


      reply	other threads:[~2011-05-02 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 20:21 [PATCH v2] wl12xx: support FW TX inactivity triggers Arik Nemtsov
2011-04-28  8:18 ` Arik Nemtsov
2011-04-29 21:09   ` Arik Nemtsov
2011-05-02  9:50     ` Luciano Coelho
2011-05-02  9:52       ` [PATCH] Revert "wl12xx: support FW TX inactivity triggers" Luciano Coelho
2011-05-02 14:37       ` [PATCH v2] wl12xx: support FW TX inactivity triggers John W. Linville
2011-05-02 14:51         ` Luciano Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304347878.12586.256.camel@cumari \
    --to=coelho@ti.com \
    --cc=arik@wizery.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox