From: Joe Perches <joe@perches.com>
To: Dan Williams <dcbw@redhat.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] libertas: Convert lbs_pr_<level> to pr_<level>
Date: Wed, 04 May 2011 14:01:06 -0700 [thread overview]
Message-ID: <1304542866.1788.102.camel@Joe-Laptop> (raw)
In-Reply-To: <1304537949.1097.8.camel@dcbw.foobar.com>
On Wed, 2011-05-04 at 14:39 -0500, Dan Williams wrote:
> On Mon, 2011-05-02 at 16:49 -0700, Joe Perches wrote:
> > Use the standard pr_<level> functions eases grep a bit.
> > Added a few missing terminating newlines to messages.
> > Coalesced long formats.
> Is there any reason to not put the pr_fmt() definition into 'defs.h'
> instead of C&P at the top of every file? I don't really care either way
> but that seems cleaner since almost all the libertas files are going to
> use logging.
It has to be before any #include <linux/kernel.h>
or any other #include that uses it.
At some point, all of the uses of
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
should be removed as I intend to have that
or an equivalent become the default.
next prev parent reply other threads:[~2011-05-04 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 23:49 [PATCH 0/2] libertas: cleanup logging styles Joe Perches
2011-05-02 23:49 ` [PATCH 1/2] libertas: Convert lbs_pr_<level> to pr_<level> Joe Perches
2011-05-04 19:39 ` Dan Williams
2011-05-04 21:01 ` Joe Perches [this message]
2011-05-04 22:15 ` Dan Williams
2011-05-02 23:49 ` [PATCH 2/2] libertas: Use netdev_<level> or dev_<level> where possible Joe Perches
2011-05-04 22:15 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304542866.1788.102.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dcbw@redhat.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).