From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:36539 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753256Ab1EEO4q (ORCPT ); Thu, 5 May 2011 10:56:46 -0400 Subject: Re: [PATCH 3/3] cfg80211/nl80211: add interval attribute for scheduled scans From: Johannes Berg To: Ben Greear Cc: Luciano Coelho , linux-wireless@vger.kernel.org, linville@tuxdriver.com In-Reply-To: <1304607500.3594.7.camel@jlt3.sipsolutions.net> (sfid-20110505_165557_965402_0D829BAA) References: <1304600420-24227-1-git-send-email-coelho@ti.com> <1304600420-24227-4-git-send-email-coelho@ti.com> <4DC2B78E.3000205@candelatech.com> <1304607108.3594.6.camel@jlt3.sipsolutions.net> <4DC2B941.6@candelatech.com> <1304607500.3594.7.camel@jlt3.sipsolutions.net> (sfid-20110505_165557_965402_0D829BAA) Content-Type: text/plain; charset="UTF-8" Date: Thu, 05 May 2011 16:59:12 +0200 Message-ID: <1304607552.3594.8.camel@jlt3.sipsolutions.net> (sfid-20110505_165648_662741_0A113083) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2011-05-05 at 16:58 +0200, Johannes Berg wrote: > On Thu, 2011-05-05 at 07:50 -0700, Ben Greear wrote: > > On 05/05/2011 07:51 AM, Johannes Berg wrote: > > > On Thu, 2011-05-05 at 07:43 -0700, Ben Greear wrote: > > >> On 05/05/2011 06:00 AM, Luciano Coelho wrote: > > >>> Introduce NL80211_ATTR_SCHED_SCAN_INTERVAL as a required attribute for > > >>> NL80211_CMD_START_SCHED_SCAN. This value informs the driver at which > > >>> intervals the scheduled scan cycles should be executed. > > >> > > >> Please default to something useful instead of requiring > > >> this so that things are backwards compatible. > > > > > > Backward compatible to what? > > > > To anything sending older style netlink messages? > > But this is a new feature, and a new command, so I don't quite > understand why an application would think it can send it without the > interval? Oh wait, I guess you're right, or this should just be part of patch 1 instead so we never have the feature without the requirement to have the interval given. johannes