From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <coelho@ti.com>
Cc: Ben Greear <greearb@candelatech.com>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 3/3] cfg80211/nl80211: add interval attribute for scheduled scans
Date: Thu, 05 May 2011 18:13:21 +0200 [thread overview]
Message-ID: <1304612001.3594.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1304610694.12586.404.camel@cumari>
On Thu, 2011-05-05 at 18:51 +0300, Luciano Coelho wrote:
> > > > But this is a new feature, and a new command, so I don't quite
> > > > understand why an application would think it can send it without the
> > > > interval?
> > >
> > > Oh wait, I guess you're right, or this should just be part of patch 1
> > > instead so we never have the feature without the requirement to have the
> > > interval given.
> >
> > Yeah, I could squish this with the previous patch (1/3), but I just
> > reckoned that patch was getting too big, so I decided to make a separate
> > one.
> >
> > If this whole patch series is taken at the same time, I guess there
> > won't be backwards compatibility problems (except for bisecting,
> > maybe?).
> >
> > Anyways, I'll leave it as your choice. Squishing the patch is easy
> > enough. ;)
>
> Ah, and one more thought... There's no driver implementing this at this
> point, so is there anything to really worry about?
Yeah, good point, no big deal. We can keep it -- I just didn't even
understand why Ben thought it would not be compatible but it makes sense
if you just look at the patch by itself.
johannes
next prev parent reply other threads:[~2011-05-05 16:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 13:00 [PATCH 0/3] cfg80211/mac80211: implementation of scheduled scan Luciano Coelho
2011-05-05 13:00 ` [PATCH 1/3] cfg80211/nl80211: add support for scheduled scans Luciano Coelho
2011-05-09 8:12 ` Johannes Berg
2011-05-09 8:17 ` Luciano Coelho
2011-05-09 8:23 ` Johannes Berg
2011-05-09 8:25 ` Luciano Coelho
2011-05-09 9:50 ` Eliad Peller
2011-05-09 13:59 ` Luciano Coelho
2011-05-05 13:00 ` [PATCH 2/3] mac80211: add support for HW scheduled scan Luciano Coelho
2011-05-09 8:22 ` Johannes Berg
2011-05-09 8:22 ` Johannes Berg
2011-05-09 13:38 ` Luciano Coelho
2011-05-05 13:00 ` [PATCH 3/3] cfg80211/nl80211: add interval attribute for scheduled scans Luciano Coelho
2011-05-05 14:43 ` Ben Greear
2011-05-05 14:51 ` Johannes Berg
2011-05-05 14:50 ` Ben Greear
2011-05-05 14:58 ` Johannes Berg
2011-05-05 14:59 ` Johannes Berg
2011-05-05 15:48 ` Luciano Coelho
2011-05-05 15:51 ` Luciano Coelho
2011-05-05 16:13 ` Johannes Berg [this message]
2011-05-05 16:22 ` Ben Greear
2011-05-05 16:29 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304612001.3594.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=coelho@ti.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).