From: Luciano Coelho <coelho@ti.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add a couple of trace event classes to reduce duplicated code
Date: Mon, 09 May 2011 14:34:58 +0300 [thread overview]
Message-ID: <1304940898.12586.449.camel@cumari> (raw)
In-Reply-To: <1304940808.12202.0.camel@jlt3.sipsolutions.net>
On Mon, 2011-05-09 at 13:33 +0200, Johannes Berg wrote:
> On Mon, 2011-05-09 at 14:27 +0300, Luciano Coelho wrote:
> > The functions drv_add_interface() and drv_remove_interface() print out
> > the same values in the traces. Combine the traces of these two
> > functions into one event class to remove some duplicate code.
> >
> > Also add a new class for functions drv_set_frag_threshold() and
> > drv_set_rts_threshold().
>
> Nice :)
>
>
> > +DECLARE_EVENT_CLASS(local_value_evt,
>
> Though I wonder if that might be better as "local_u32_evt"?
Yeah, I thought about it too... I'll send v2.
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-05-09 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 11:27 [PATCH] mac80211: add a couple of trace event classes to reduce duplicated code Luciano Coelho
2011-05-09 11:33 ` Johannes Berg
2011-05-09 11:34 ` Luciano Coelho [this message]
2011-05-09 11:40 ` [PATCH v2] " Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304940898.12586.449.camel@cumari \
--to=coelho@ti.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox