Re: [PATCH 1/3] cfg80211/nl80211: add support for scheduled scans

[Luciano Coelho <coelho@ti.com>]

On Mon, 2011-05-09 at 12:50 +0300, Eliad Peller wrote:
> On Thu, May 5, 2011 at 4:00 PM, Luciano Coelho <coelho@ti.com> wrote:
> > Implement new functionality for scheduled scan offload.  With this feature we
> > can scan automatically at certain intervals.
> >
> > The idea is that the hardware can perform scan automatically and filter on
> > desired results without waking up the host unnecessarily.
> >
> > Add NL80211_CMD_START_SCHED_SCAN and NL80211_CMD_STOP_SCHED_SCAN
> > commands to the nl80211 interface.  When results are available they are
> > reported by NL80211_CMD_SCHED_SCAN_RESULTS events.  The userspace is
> > informed when the scheduled scan has stopped with a
> > NL80211_CMD_SCHED_SCAN_STOPPED event, which can be triggered either by
> > the driver or by a call to NL80211_CMD_STOP_SCHED_SCAN.
> >
> > Signed-off-by: Luciano Coelho <coelho@ti.com>
> > ---
> [...]
> 
> > +
> > +       err = rdev->ops->sched_scan_start(&rdev->wiphy, dev, request);
> > +       if (!err)
> > +               nl80211_send_sched_scan(rdev, dev,
> > +                                       NL80211_CMD_START_SCHED_SCAN);
> > +       else {
> > +out_free:
> > +               kfree(request);
> > +               rdev->sched_scan_req = NULL;
> > +       }
> > +
> > +       return err;
> > +}
> 
> i know it's the same in nl80211_trigger_scan(), but it still looks
> very odd - goto into else block?!

Good point, looks a bit ugly and it was indeed copied.  I'll clean it up
a bit.

-- 
Cheers,
Luca.