From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/7] wl12xx: add ps completion event
Date: Thu, 12 May 2011 23:10:34 +0300 [thread overview]
Message-ID: <1305231034.12586.1038.camel@cumari> (raw)
In-Reply-To: <1305104068-32240-7-git-send-email-eliad@wizery.com>
On Wed, 2011-05-11 at 11:54 +0300, Eliad Peller wrote:
> Signal when psm was entered successfully, if the completion
> variable is being set.
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
> drivers/net/wireless/wl12xx/event.c | 7 +++++++
> drivers/net/wireless/wl12xx/wl12xx.h | 1 +
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/event.c b/drivers/net/wireless/wl12xx/event.c
> index ae69330..21e52ed 100644
> --- a/drivers/net/wireless/wl12xx/event.c
> +++ b/drivers/net/wireless/wl12xx/event.c
> @@ -135,6 +135,13 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
>
> /* enable beacon early termination */
> ret = wl1271_acx_bet_enable(wl, true);
> + if (ret < 0)
> + break;
> +
> + if (wl->ps_compl) {
> + complete(wl->ps_compl);
> + wl->ps_compl = NULL;
> + }
> break;
> default:
> break;
> diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
> index daf941d..cf08a9d 100644
> --- a/drivers/net/wireless/wl12xx/wl12xx.h
> +++ b/drivers/net/wireless/wl12xx/wl12xx.h
> @@ -512,6 +512,7 @@ struct wl1271 {
> unsigned int rx_filter;
>
> struct completion *elp_compl;
> + struct completion *ps_compl;
> struct delayed_work elp_work;
> struct delayed_work pspoll_work;
>
This patch doesn't make sense by itself, without the next one. Can you
squash them?
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-05-12 20:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 8:54 [PATCH 0/7] wl12xx: add initial wowlan support Eliad Peller
2011-05-11 8:54 ` [PATCH 1/7] wl12xx_sdio: set interrupt as wake_up interrupt Eliad Peller
2011-05-11 8:54 ` [PATCH 2/7] wl12xx: declare suspend/resume callbacks (for wowlan) Eliad Peller
2011-05-11 8:54 ` [PATCH 3/7] wl12xx_sdio: set MMC_PM_KEEP_POWER flag on suspend Eliad Peller
2011-05-11 8:54 ` [PATCH 4/7] wl12xx: prevent scheduling while suspending (WoW enabled) Eliad Peller
2011-05-12 19:48 ` Luciano Coelho
2011-05-12 19:52 ` Johannes Berg
2011-05-12 20:09 ` Luciano Coelho
2011-05-13 7:41 ` Eliad Peller
2011-05-11 8:54 ` [PATCH 5/7] wl12xx_sdio: declare support for NL80211_WOW_TRIGGER_ANYTHING trigger Eliad Peller
2011-05-11 8:54 ` [PATCH 6/7] wl12xx: add ps completion event Eliad Peller
2011-05-12 20:10 ` Luciano Coelho [this message]
2011-05-13 7:42 ` Eliad Peller
2011-05-11 8:54 ` [PATCH 7/7] wl12xx: enter/exit psm on wowlan suspend/resume Eliad Peller
2011-05-12 20:24 ` Luciano Coelho
2011-05-13 7:44 ` Eliad Peller
2011-05-11 8:57 ` [PATCH 0/7] wl12xx: add initial wowlan support Luciano Coelho
2011-05-11 16:52 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305231034.12586.1038.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox