From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Javier Cardona <javier@cozybit.com>
Subject: Re: [PATCH] mac80211: fix and simplify mesh locking
Date: Sat, 14 May 2011 11:20:03 +0200 [thread overview]
Message-ID: <1305364803.3437.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1305363652.3437.8.camel@jlt3.sipsolutions.net> (sfid-20110514_110059_273421_3D561F0E)
On Sat, 2011-05-14 at 11:00 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The locking in mesh_{mpath,mpp}_table_grow not only
> has an rcu_read_unlock() missing, it's also racy
> (though really only technically since it's invoked
> from a single function only) since it obtains the
> new size of the table without any locking, so two
> invocations of the function could attempt the same
> resize.
Actually, it _can_ happen, if you have multiple mesh interfaces.
johannes
next prev parent reply other threads:[~2011-05-14 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 9:00 [PATCH] mac80211: fix and simplify mesh locking Johannes Berg
2011-05-14 9:20 ` Johannes Berg [this message]
2011-05-17 23:05 ` Javier Cardona
2011-05-17 23:13 ` [PATCH] mac80211: Don't sleep when growing the mesh path Javier Cardona
2011-05-18 22:45 ` [PATCH] mac80211: fix and simplify mesh locking Johannes Berg
2011-05-19 1:40 ` Javier Cardona
2011-05-19 4:14 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305364803.3437.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).