From: Johannes Berg <johannes@sipsolutions.net>
To: Matteo Croce <matteo@openwrt.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] 802.11n frame injection
Date: Wed, 18 May 2011 15:49:08 -0700 [thread overview]
Message-ID: <1305758948.8827.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <BANLkTinp0Hy3yhfxAEAX9jeKSaYRMddDew@mail.gmail.com> (sfid-20110515_000810_416041_D36F7A6B)
On Sun, 2011-05-15 at 00:07 +0200, Matteo Croce wrote:
> >> + rthdr->ht_mcs = info->status.rates[0].idx;
> >> + if (info->status.rates[0].flags & IEEE80211_TX_RC_40_MHZ_WIDTH)
> >> + rthdr->ht_flag |= IEEE80211_RADIOTAP_MCS_BW_40;
> >> + if (info->status.rates[0].flags & IEEE80211_TX_RC_SHORT_GI)
> >> + rthdr->ht_flag |= IEEE80211_RADIOTAP_MCS_SGI;
> >> + }
> >
> > I think you should also split the patch -- this part isn't really only
> > injection.
> After injecting a frame I have a TX feedback, why shouldn't it have
> correct MCS informations?
... yeah but I said it's not _only_ injection, you also have TX feedback
w/o injection, so this isn't injection related.
johannes
prev parent reply other threads:[~2011-05-18 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 16:34 [PATCH v2] 802.11n frame injection Matteo Croce
2011-04-24 8:15 ` Johannes Berg
2011-04-24 19:14 ` Maxim Levitsky
2011-04-24 20:42 ` Matteo Croce
2011-05-11 16:49 ` John W. Linville
2011-05-11 17:06 ` Johannes Berg
2011-05-14 22:07 ` Matteo Croce
2011-05-18 22:49 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305758948.8827.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=matteo@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).