From: wwguy <wey-yi.w.guy@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/1] nl80211: check return code for genlmsg_end
Date: Wed, 18 May 2011 17:10:27 -0700 [thread overview]
Message-ID: <1305763827.10450.19.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1305759898.8827.7.camel@jlt3.sipsolutions.net>
On Wed, 2011-05-18 at 16:04 -0700, Johannes Berg wrote:
> On Mon, 2011-05-16 at 07:24 -0700, Wey-Yi Guy wrote:
> > Check the return value for genlmsg_end and handle it.
>
> It can never return < 0:
>
> /**
> * nlmsg_end - Finalize a netlink message
> * @skb: socket buffer the message is stored in
> * @nlh: netlink message header
> *
> * Corrects the netlink message header to include the appeneded
> * attributes. Only necessary if attributes have been added to
> * the message.
> *
> * Returns the total data length of the skb.
>
do we should remove all the checking all together?
Wey
>
prev parent reply other threads:[~2011-05-19 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 14:24 [PATCH 1/1] nl80211: check return code for genlmsg_end Wey-Yi Guy
2011-05-18 23:04 ` Johannes Berg
2011-05-19 0:10 ` wwguy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305763827.10450.19.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox