From: Ben Hutchings <ben@decadent.org.uk>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>,
Mike McCormack <mikem@ring3k.org>,
linux-wireless@vger.kernel.org
Subject: Re: rtl8192se replacing rtl8192e?
Date: Tue, 31 May 2011 04:20:13 +0100 [thread overview]
Message-ID: <1306812013.4277.89.camel@localhost> (raw)
In-Reply-To: <4DE45D54.9050301@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On Mon, 2011-05-30 at 22:15 -0500, Larry Finger wrote:
> On 05/30/2011 04:34 PM, Ben Hutchings wrote:
> > I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims
> > PCI device ID 10ec:8192, which is already claimed by staging driver
> > rtl8192e. Is it intended to replace that driver, or are there two
> > different devices with that ID which they will distinguish in their
> > probe functions?
> >
> > If is intended to replace rtl8192e, shouldn't it also claim these device
> > IDs?
> >
> > /* Corega */
> > { PCI_DEVICE(0x07aa, 0x0044) },
> > { PCI_DEVICE(0x07aa, 0x0047) },
>
> The RTL8192E is a different device than the RTL8192SE, thus rtl8192se will not
> replace rtl8192e. The way to tell them apart is the PCIe revision id. At
> present, I don't have a method to use that info to load the correct driver, but
> I will be working on it.
It doesn't matter too much if both drivers get loaded, so long as their
respective probe() functions fail cleanly and return -ENODEV when called
for the wrong device.
> In addition, I need to acquire an RTL8192E.
>
> No, rtl8192se should not claim those Corega devices.
Thanks.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-05-31 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 21:34 rtl8192se replacing rtl8192e? Ben Hutchings
2011-05-31 3:15 ` Larry Finger
2011-05-31 3:20 ` Ben Hutchings [this message]
2011-05-31 3:29 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306812013.4277.89.camel@localhost \
--to=ben@decadent.org.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=mikem@ring3k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).