From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: Shahar Levi <shahar_levi@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: Add Support for Low Power DRPw (LPD) Mode
Date: Tue, 31 May 2011 12:16:06 +0300 [thread overview]
Message-ID: <1306833366.23002.52.camel@cumari> (raw)
In-Reply-To: <BANLkTikGm1KwNTXXHTjM0K1tVNOPpi2BLQ@mail.gmail.com>
On Tue, 2011-05-31 at 12:11 +0300, Eliad Peller wrote:
> On Tue, May 31, 2011 at 11:35 AM, Luciano Coelho <coelho@ti.com> wrote:
> > On Tue, 2011-05-31 at 10:51 +0300, Shahar Levi wrote:
> >> The Low Power DRPw (LPD) mode contains several optimizations
> >> that designed to reduce the solution's consumption. The
> >> purpose is to save current consumption in RX and Listen mode.
> >>
> >> LPD setting apply only for wl127x AP mode (not wl128x)
> >>
> >> Signed-off-by: Shahar Levi <shahar_levi@ti.com>
> >> ---
> >
> > [...]
> >
> >
> > I still think this is not the right way to do it. It doesn't make sense
> > to have it in the configuration parameters. If you want to make it
> > configurable, it should be in the NVS file and the driver should clear
> > it when not in AP mode (and whoever generates the NVS needs to make sure
> > it's never set for wl128x).
> >
> please don't use the "blacklist" approach. it always gets broken at some point.
I totally agree.
> > The other solution is to always set this flag when in wl127x in AP-mode,
> > in which case it doesn't need to be configurable at all. That would be
> > the simplest solution and you could even use a quirk if it makes it
> > easier.
> >
> sounds much better.
Yes, and now we got confirmation that this is really the case. It
should always be set for wl127x in AP-mode and not be set for anything
else. This is a clear case, not a configurable value.
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-05-31 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 7:51 [PATCH] wl12xx: Add Support for Low Power DRPw (LPD) Mode Shahar Levi
2011-05-31 8:35 ` Luciano Coelho
2011-05-31 9:11 ` Eliad Peller
2011-05-31 9:16 ` Luciano Coelho [this message]
2011-05-31 11:17 ` Levi, Shahar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306833366.23002.52.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=shahar_levi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).