From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:35591 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251Ab1EaJQL (ORCPT ); Tue, 31 May 2011 05:16:11 -0400 Received: by mail-bw0-f42.google.com with SMTP id 18so3843848bwz.29 for ; Tue, 31 May 2011 02:16:10 -0700 (PDT) Subject: Re: [PATCH] wl12xx: Add Support for Low Power DRPw (LPD) Mode From: Luciano Coelho To: Eliad Peller Cc: Shahar Levi , linux-wireless@vger.kernel.org In-Reply-To: References: <1306828287-31802-1-git-send-email-shahar_levi@ti.com> <1306830902.23002.18.camel@cumari> Content-Type: text/plain; charset="UTF-8" Date: Tue, 31 May 2011 12:16:06 +0300 Message-ID: <1306833366.23002.52.camel@cumari> (sfid-20110531_111615_386151_0411EFD2) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2011-05-31 at 12:11 +0300, Eliad Peller wrote: > On Tue, May 31, 2011 at 11:35 AM, Luciano Coelho wrote: > > On Tue, 2011-05-31 at 10:51 +0300, Shahar Levi wrote: > >> The Low Power DRPw (LPD) mode contains several optimizations > >> that designed to reduce the solution's consumption. The > >> purpose is to save current consumption in RX and Listen mode. > >> > >> LPD setting apply only for wl127x AP mode (not wl128x) > >> > >> Signed-off-by: Shahar Levi > >> --- > > > > [...] > > > > > > I still think this is not the right way to do it. It doesn't make sense > > to have it in the configuration parameters. If you want to make it > > configurable, it should be in the NVS file and the driver should clear > > it when not in AP mode (and whoever generates the NVS needs to make sure > > it's never set for wl128x). > > > please don't use the "blacklist" approach. it always gets broken at some point. I totally agree. > > The other solution is to always set this flag when in wl127x in AP-mode, > > in which case it doesn't need to be configurable at all. That would be > > the simplest solution and you could even use a quirk if it makes it > > easier. > > > sounds much better. Yes, and now we got confirmation that this is really the case. It should always be set for wl127x in AP-mode and not be set for anything else. This is a clear case, not a configurable value. -- Cheers, Luca.