* [PATCH] bluetooth l2cap: fix locking in l2cap_global_chan_by_psm
@ 2011-06-01 6:29 Johannes Berg
2011-06-01 18:51 ` John W. Linville
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2011-06-01 6:29 UTC (permalink / raw)
To: John W. Linville; +Cc: Gustavo F. Padovan, linux-wireless
From: Johannes Berg <johannes.berg@intel.com>
read_lock() ... read_unlock_bh() is clearly bogus.
This was broken by
commit 23691d75cdc69c3b285211b4d77746aa20a17d18
Author: Gustavo F. Padovan <padovan@profusion.mobi>
Date: Wed Apr 27 18:26:32 2011 -0300
Bluetooth: Remove l2cap_sk_list
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/bluetooth/l2cap_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/bluetooth/l2cap_core.c 2011-06-01 08:27:44.000000000 +0200
+++ b/net/bluetooth/l2cap_core.c 2011-06-01 08:27:51.000000000 +0200
@@ -906,7 +906,7 @@ static struct l2cap_chan *l2cap_global_c
if (c->psm == psm) {
/* Exact match. */
if (!bacmp(&bt_sk(sk)->src, src)) {
- read_unlock_bh(&chan_list_lock);
+ read_unlock(&chan_list_lock);
return c;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bluetooth l2cap: fix locking in l2cap_global_chan_by_psm
2011-06-01 6:29 [PATCH] bluetooth l2cap: fix locking in l2cap_global_chan_by_psm Johannes Berg
@ 2011-06-01 18:51 ` John W. Linville
0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2011-06-01 18:51 UTC (permalink / raw)
To: Johannes Berg; +Cc: Gustavo F. Padovan, linux-wireless
On Wed, Jun 01, 2011 at 08:29:54AM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> read_lock() ... read_unlock_bh() is clearly bogus.
> This was broken by
>
> commit 23691d75cdc69c3b285211b4d77746aa20a17d18
> Author: Gustavo F. Padovan <padovan@profusion.mobi>
> Date: Wed Apr 27 18:26:32 2011 -0300
>
> Bluetooth: Remove l2cap_sk_list
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Gustavo, I'm taking this in wireless-2.6 directly.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-01 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-01 6:29 [PATCH] bluetooth l2cap: fix locking in l2cap_global_chan_by_psm Johannes Berg
2011-06-01 18:51 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).